PR for #25 - UWP system.io.file.exsts fixes #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…!= null, it exists (avoids System.IO checks that return invalid state).
|
I hope all is well. I was wondering if you had a chance to take a look at this? I would like to move ahead, but not sure if you're thinking of accepting this PR, or what...? |
|
@jasells apologies, I have been on holiday recently and haven't been as active online. I'll give this a review now. |
Removed commented out code.
Removed commented out code
jamesmcroft
changed the title
|
Related - #25 |
|
More than happy with this fix. Will get a new NuGet package out ASAP |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This works as expected on UWP.