Skip to content

Commit

Permalink
fix(Select): Don’t spread className to native control
Browse files Browse the repository at this point in the history
  • Loading branch information
jamesmfriedman committed Apr 6, 2018
1 parent 80917c0 commit 54c6fc3
Showing 2 changed files with 22 additions and 4 deletions.
10 changes: 7 additions & 3 deletions src/Select/index.js
Original file line number Diff line number Diff line change
@@ -56,9 +56,12 @@ export type SelectPropsT = {
placeholder?: string,
/** Disables the form control. */
disabled?: boolean,
/** Makes the Select have a visiual box. */
box?: boolean
/** Props for the root element. By default, additonal props spread to the native select element. */
/** Makes the Select have a visual box. */
box?: boolean,
/** Props for the root element. By default, additional props spread to the native select element. */
rootProps?: Object,
/** A className for the root element. */
className?: string
} & SimpleTagPropsT;

/**
@@ -110,6 +113,7 @@ export class Select extends withFoundation({
label = '',
options = [],
box,
className,
rootProps = {},
...rest
} = this.props;
16 changes: 15 additions & 1 deletion src/docs/docgen.json
Original file line number Diff line number Diff line change
@@ -2939,7 +2939,21 @@
"name": "boolean"
},
"required": false,
"description": "Makes the Select have a visiual box."
"description": "Makes the Select have a visual box."
},
"rootProps": {
"flowType": {
"name": "Object"
},
"required": false,
"description": "Props for the root element. By default, additional props spread to the native select element."
},
"className": {
"flowType": {
"name": "string"
},
"required": false,
"description": "A className for the root element."
}
}
}

0 comments on commit 54c6fc3

Please sign in to comment.