Skip to content

Commit

Permalink
docs(Node Version): Adding node version 7 as a requirement in contrib…
Browse files Browse the repository at this point in the history
…uting #129 #179
  • Loading branch information
James Friedman committed Apr 5, 2018
1 parent bde5cd3 commit c541d96
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 6 deletions.
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ We strive to make developing RMWC as frictionless as possible, both for ourselve

### Setting up your development environment

You'll need a recent version of [nodejs](https://nodejs.org/en/) to work on RMWC. We test using both the latest node versions, so use the latest where possible.
You'll need a recent version of [nodejs](https://nodejs.org/en/) to work on RMWC. We test using the latest node versions, so use the latest where possible. The dev environment is verified to work with Node versions 7 and up.

> **NOTE**: If you expect to commit updated or new dependencies, please ensure you are using npm 5, which will
> also update `package-lock.json` correctly when you install or upgrade packages.
Expand Down
15 changes: 10 additions & 5 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -33,20 +33,24 @@
},
"scripts": {
"start": "react-app-rewired start",
"build": "npm run docgen && react-app-rewired build && rm -R docs && mv build docs && cp docs/index.html docs/404.html",
"build":
"npm run docgen && react-app-rewired build && rm -R docs && mv build docs && cp docs/index.html docs/404.html",
"test": "react-app-rewired test --env=jsdom",
"test:ssr": "react-app-rewired test --env=jsdom",
"babelfy": "node scripts/babelfy.js",
"clean": "node scripts/clean.js",
"prepublishOnly": "npm run babelfy",
"postpublish": "npm run clean",
"docgen": "export NODE_ENV=development && react-docgen ./src --exclude=/\\.\\(story\\|docs\\|spec\\)\\.js/ --pretty --resolver ./scripts/docgen-resolver.js -o ./src/docs/docgen.json",
"docgen":
"export NODE_ENV=development && react-docgen ./src --exclude=/\\.\\(story\\|docs\\|spec\\)\\.js/ --pretty --resolver ./scripts/docgen-resolver.js -o ./src/docs/docgen.json",
"build:lib": "node scripts/build-lib.js",
"deploy:docs": "npm run build && git add docs -f && git commit -m 'Deploying docs' && git push --force && npm run clean",
"deploy:docs":
"npm run build && git add docs -f && git commit -m 'Deploying docs' && git push --force && npm run clean",
"changelog": "changelog",
"storybook": "start-storybook -p 6006",
"preversion": "npm test -- --coverage",
"version": "npm run changelog && git add CHANGELOG.md && npm run build:lib && git add -A lib && npm run build && git add docs -f",
"version":
"npm run changelog && git add CHANGELOG.md && npm run build:lib && git add -A lib && npm run build && git add docs -f",
"postversion": "git push && git push --tags"
},
"devDependencies": {
Expand All @@ -73,7 +77,8 @@
"react-app-rewired": "^1.4.0",
"react-dom": "^16.2.0",
"react-hot-loader": "^3.1.3",
"react-markdown-loader": "git+https://github.com/jamesmfriedman/react-markdown-loader.git#master",
"react-markdown-loader":
"git+https://github.com/jamesmfriedman/react-markdown-loader.git#master",
"react-router-dom": "^4.2.2",
"react-scripts": "^1.1.1"
}
Expand Down

0 comments on commit c541d96

Please sign in to comment.