Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TextFields lose MDC controlled classNames when className prop is passed #128

Closed
jamesmfriedman opened this issue Jan 25, 2018 · 2 comments
Closed
Labels

Comments

@jamesmfriedman
Copy link
Collaborator

<TextField className="foo"/>

When this field is typed in, it will appear focused until it re-renders on value change. The TextField will then lose its focused class.

One potential fix is to manually assign the classes. Another one is to mimic the Ripple component and collect all MDC classes to pass along.

@NSWIDER
Copy link

NSWIDER commented Aug 14, 2018

In 1.8.3 TextField always loses class name.

@jamesmfriedman
Copy link
Collaborator Author

@NSWIDER do you have a repro of your issue? The className on TextField gets added to the TextField container, not the input itself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants