Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple issues with code on pypi page #116

Open
Protofall opened this issue Oct 9, 2020 · 2 comments
Open

Multiple issues with code on pypi page #116

Protofall opened this issue Oct 9, 2020 · 2 comments

Comments

@Protofall
Copy link

Protofall commented Oct 9, 2020

I tried running the example code on the pypi page, but there were multiple errors. Aside from undefined variables, I found

  • p.gender('f') raises BadGenderError since 'f' isn't in singular_pronoun_genders
  • Something like print("There" + p.plural_verb("was", errors) + p.no(" error", errors)) prints There[3 SPACES]were[2 SPACES]6[1 SPACE]errors. There's too much whitespace. This happens for many of the functions
  • run/running or run/runner fail all 4 of the compare checks. Not sure if function is broken or that's just a missing case.
  • join() function can't be found at runtime (When installed via pip3) even though I can see it in the downloaded source code from the pypi website.
@jaraco
Copy link
Owner

jaraco commented Nov 15, 2020

Thanks for the report, and I'm happy to accept a pull request to repair the issue(s).

Ideally, the docs would be implemented as executable docstrings, such that they're validated as part of the test suite, but it's not obvious to me where those examples should go (as top-level inflect module doc, maybe?). That would be a stretch goal. Just getting the docs to work as advertised is probably sufficient.

Any help you can provide would be appreciated. Thanks!

@jaraco
Copy link
Owner

jaraco commented Jul 9, 2022

  • join() function can't be found at runtime (When installed via pip3) even though I can see it in the downloaded source code from the pypi website.

This issue was addressed in #155.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants