-
-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix s plural noun #168
Fix s plural noun #168
Conversation
Signed-off-by: George Araujo <[email protected]>
…s' for 'es' Signed-off-by: George Araujo <[email protected]>
Signed-off-by: George Araujo <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Thanks for the contrib. Can you add a test that captures the known bad cases (fails before and passes after this change)?
Sure, but some of the failing cases are already there. I gave a quick look at your testing code and couldn't understand it, so I need to do a deep dive. Does your test code test the opposite, and also the same case? I mean, for example:
Does your testing code tests
? |
Signed-off-by: George Araujo <[email protected]>
I'm not sure, but I'm guessing not. Historically, the project assumes valid inputs, so a call of I'm happy to accept more sophistication, but the status quo is somewhat limited. |
Actually some of the failing cases are like you said, |
Signed-off-by: George Araujo <[email protected]>
Added test cases like |
Oops. I merged this not double-checking the tests and I see now they're failing, so I've force-pushed without those changes. Please re-submit. |
Fixes #161