Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API for captive portal status #62

Open
ghost opened this issue Jan 19, 2021 · 6 comments
Open

API for captive portal status #62

ghost opened this issue Jan 19, 2021 · 6 comments
Assignees
Labels
backlog Issues backlogged for inclusion in future releases feature request New feature or request needs research Issues that require further research

Comments

@ghost
Copy link

ghost commented Jan 19, 2021

Can you add an end point to get captive portal status.
Thank you.

@jaredhendrickson13 jaredhendrickson13 added backlog Issues backlogged for inclusion in future releases feature request New feature or request needs research Issues that require further research labels Jan 29, 2021
@jaredhendrickson13
Copy link
Owner

Hey!

Thanks for the request. I'll do some research and see what this would take. I'll provide an update when I've had a chance to take a look.

Thanks again!

@ghost
Copy link
Author

ghost commented Jan 30, 2021

Can you point me to resources where I can learn and start building stuff like these myself.
Thank you.

@jaredhendrickson13
Copy link
Owner

You can refer to the contributors guide to learn the framework and start building your own API endpoints. You may also use the existing code as reference for your code.

It helps to have a good understanding of the pfSense code, PHP, and FreeBSD 11/12. You can refer to these documents:

If you plan on merging your code into this project, you should also have a good understanding of Python3 to write unit tests as well as REST architecture:

@jaredhendrickson13 jaredhendrickson13 removed the backlog Issues backlogged for inclusion in future releases label Mar 22, 2021
@jaredhendrickson13 jaredhendrickson13 self-assigned this Mar 22, 2021
@tjsas1
Copy link

tjsas1 commented Mar 29, 2021

Will this include Vouchers and allowed mac and ip?

@jaredhendrickson13
Copy link
Owner

@tjsas1 the work I have staged for this particular feature will only include data found under Status > Captive Portal within the UI. I believe the data you are referring to is found under Services > Captive Portal, which would need to be factored into a separate endpoint. If that is a desired feature, feel free to open a feature request and I'll see what I can do.

@jaredhendrickson13 jaredhendrickson13 added the backlog Issues backlogged for inclusion in future releases label Oct 15, 2021
@lmjaromay
Copy link

@jaredhendrickson13 Any news on this? we are actually eyeing to do a few automations in the vouchers and this api has been of really great help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backlog Issues backlogged for inclusion in future releases feature request New feature or request needs research Issues that require further research
Projects
None yet
Development

No branches or pull requests

3 participants