Low priority validation causing problems

[danielkcz]

🐛 Bug report

Current Behavior

Basically, when values are modified with setValues, it won't trigger the validation and causes inconsistent outcome - validation errors are still shown despite valid values entered.

Expected behavior

Setting values imperatively should probably be a high priority validation.

Reproducible example

https://codesandbox.io/s/zen-hoover-p66mv

• focus & blur one of the fields to show error
• click autofill button
• error is still shown despite the valid value

Downgrading to RC-1 fixes it.

[rohitkrai03]

I am facing this issue as well. @jaredpalmer Is there an ETA on this?

[danielkcz]

The current workaround is to call formik.validateForm after the formik.setValues to execute high priority validation. Here is a modified example that shows it... https://codesandbox.io/s/elastic-poincare-6fr2l

Note, it's necessary to call it with the same values otherwise it will see previous ones.

[jaredpalmer]

I really wish I never added validation as a side effect of the setXXX methods.

The current workaround as @FredyC would be to avoid validation on setValues and trigger it imperatively.

@FredyC what would the ideal API look like? Do we need to expose validateFormWithLowPriority() and validateFormWithHighPriority()? Also note, that we also have #1526 and could introduce debouncedValidateForm()

[jaredpalmer]

I've messaged some React team members about this and will report back with a suggested solution.

[danielkcz]

@jaredpalmer I think I've found the culprit...

formik/src/Formik.tsx

Line 463 in 3c86588

? validateFormWithLowPriority(state.values)

You are using state.values which is not up to date yet (this isn't synchronous Redux 😉). You need to use values you have in argument :) Perhaps verify there aren't more spots like that, it's a fairly easy mistake to do.

Btw, validateFormWithHighPriority is already exposed as validateForm, but it's far from ideal because if you forget to pass new values, it's the same problem and validating against old values. I would say it's fairly useless as that.

[jaredpalmer]

@FredyC that makes sense.

[jaredpalmer]

perhaps only handleChange and handleBlur should be low-priority.

[danielkcz]

Well, I don't think it's a problem to have low priority here, it just needs to validate against new data.

[viniciusdacal]

Anyone working on this? I could give it a shot if you don't mind.

[frantic1048]

Encountered same issue with setFieldValue(), and I found setFieldValue() also uses validateFormWithLowPriority to trigger validation 🤔

version: 2.0.1-rc.13