Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing the script naming for the with-reason-react example #308

Closed
bjrnt opened this issue Jul 9, 2017 · 1 comment
Closed

Changing the script naming for the with-reason-react example #308

bjrnt opened this issue Jul 9, 2017 · 1 comment

Comments

@bjrnt
Copy link
Contributor

bjrnt commented Jul 9, 2017

Hi,

When creating a new project with reason-react the following guide appears:

To start a local server for development:
  yarn start

but as shown inside the reason-react example, yarn run dev and not yarn start is required to run the example.

If you just run yarn start, you get a cryptic error message that doesn't really help:

❯ npm start

> [email protected] start 
> NODE_ENV=production node build/server.js

module.js:487
    throw err;
    ^

Error: Cannot find module 'build/server.js'

Either changing the post-installation message or changing the scripts required to run the reason-react example would help beginners get started. I'd be happy to PR this if needed.

@jaredpalmer
Copy link
Owner

Ahh I see what you mean, sorry about that. Feel free to submit a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants