Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3.6 support #287

Closed
stkw0 opened this issue Jun 20, 2018 · 5 comments
Closed

python3.6 support #287

stkw0 opened this issue Jun 20, 2018 · 5 comments

Comments

@stkw0
Copy link
Contributor

stkw0 commented Jun 20, 2018

For what I can read on the setup.py of buku, python3.6 is supported, but one of the dependencies of bukuserver (this: https://github.com/lixxu/flask-paginate ) doesn't support python3.6 (only 2 and 3.4).

Moreover, flask-paginate don't seems to be very active.

Should buku use an alternative library, or it's better to open an issue on flask-paginate asking for python3.6 support?

Thanks

@jarun
Copy link
Owner

jarun commented Jun 20, 2018

@rachmadaniHaryono can you please check this?

@rachmadaniHaryono
Copy link
Collaborator

Should buku use an alternative library, or it's better to open an issue on flask-paginate asking for python3.6 support?

I haven't check if there is another alternative for that library,but imo because current llibrary work and there is no hack/edit to be done for python 3.5 3.6 ,so we can keep using it

If user with that python version find problem with pagination, we will try to fix that it and if possible create pr for flask-paginate

Cc @lixxu

@stkw0
Copy link
Contributor Author

stkw0 commented Jun 21, 2018

Is it possible to import a python3.4 library from python3.6? Python3.4 is reaching EOL in 2019, anyway

@rachmadaniHaryono
Copy link
Collaborator

It is possible As Long there is no restrictions on library

@stkw0
Copy link
Contributor Author

stkw0 commented Jun 21, 2018

If the library can work with python3.6 without troubles, isn't supposed that the library also add 3.6 to the list of supported versions?

To put a little bit of context, I was trying to create the package for the new version of buku and bukuserver. Gentoo tomorrow will make python3.6 the default (https://www.gentoo.org/support/news-items/2018-05-22-python3-6.html). In theory as buku supports 3.6 it's not a problem, but having dependencies without support for 3.6 is a problem.

As this seems more a problem of flask-paginate, I will open an issue there

@rachmadaniHaryono rachmadaniHaryono mentioned this issue Jun 29, 2018
61 tasks
@jarun jarun closed this as completed Jun 30, 2018
@github-actions github-actions bot locked and limited conversation to collaborators Jun 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants