Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

<EMPTY TAG> #807

Open
electricmessiah opened this issue Jan 3, 2025 · 2 comments · May be fixed by #814
Open

<EMPTY TAG> #807

electricmessiah opened this issue Jan 3, 2025 · 2 comments · May be fixed by #814

Comments

@electricmessiah
Copy link

electricmessiah commented Jan 3, 2025 •
edited
Loading

I had a problem with FireFox exported bookmarks. If there are nested folders that are placed above existing links in the tree everything (links and any folder with links) below will be skipped and thus not tagged properly as their folder name. I've confirmed the issue with several tests. I don't know if it's a FireFox problem with how the bookmark markup is written, or if it is with the Buku parser (likely).

This fails to properly tag links in folders

- - Folder 2017
- - - Folder 2017 Apps
- - - - Link 1
- - - - Folder 2017 Games (< EMPTY TAG > NOT tagged with folder 2017-Games)
- - - - - Link 1
- - - Link 1
- - - Link 2

This works when placing the folder below the existing links

- - Folder 2017
- - - Link 1
- - - Link 2
- - - Folder 2017 Apps
- - - - Link 1
- - - - Folder 2017 Games (< EMPTY TAG > NOT tagged with folder 2017-Games)
- - - - - Link 1
@LeXofLeviafan
Copy link
Collaborator

LeXofLeviafan commented Jan 3, 2025 •
edited
Loading

…Could you provide those examples in raw HTML? You can use ``` or ~~~ for multiline verbatim blocks, e.g.:

```html
The multiline content goes here; <tags>, _formatting chars_ and    whitespace    are retained as-is.
   (that "html" word after the initial "```" is optional and enables HTML syntax highlighting)
```

Having a (minimal) file example that can be used to directly reproduce the problem would be handy when trying to fix it 🙂

If the example is lengthy, you can put it into a (clickable) collapsible content block like this 
<details><summary>Handle (e.g. name of the example)</summary>

```html
The long example goes here. (Note the blank line before "```html")
```
</details>

…Also – which version are you using? E.g. v4.9 release (installed from PyPI), or nightly (installed from GitHub)?

@electricmessiah
Copy link
Author

Here are two exported Firefox bookmark files. You can see the folder above links is not working, but below is.

bukutest.zip

LeXofLeviafan added a commit to LeXofLeviafan/buku that referenced this issue Jan 19, 2025
@LeXofLeviafan
[jarun#807] fixed import in single-parent-folder-tag mode
c31c6bf
@LeXofLeviafan LeXofLeviafan linked a pull request Jan 19, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[jarun#807] fixed import in single-parent-folder-tag mode LeXofLeviafan/buku
2 participants
@electricmessiah @LeXofLeviafan