expect(null).toEqual(jasmine.any(Object)) passes

[lmj0011]

version
jasmine v2.5.3
jasmine-core v2.5.2

environment
node v6.9.4
npm v3.10.10

running Jasmine
from cli using the jasmine command to run my tests

I'm expecting this to fail, but it doesn't.
How does null equal an Object?

expect(null).toEqual(jasmine.any(Object));

[JamieMason]

I think these lines in /src/core/asymmetric_equality/Any.js:26-28 could be the problem and the following snippet should be enough to fix it AFAICT.

    if (this.expectedObject == Object) {
      return Object.prototype.toString.call(other) == '[object Object]';
    }

[lmj0011]

@JamieMason

I suppose in this context using == or === doesn't matter.
other than that, it looks legit.

you wanted to make the PR for this?

[JamieMason]

I suppose in this context using == or === doesn't matter.

Yeah I'd normally use === but I notice the rest of that file is using ==.

you wanted to make the PR for this?

I don't mind yeah, I'll try and fit it in today 👍

[slackersoft]

I'm not sure if we can change this behavior for any right now, since that has a potential to break existing suites. That said, I think for 3.0 (when we can break things :), we'll want to look at the provided asymmetric matchers to ensure we are providing the right options out of the box.