Is Win32Exception.addSuppressedReflected() still needed?

[dEajL3kA]

As far as I can tell, Win32Exception.addSuppressedReflected() is a "hack" to support old JDK versions that did not have Throwable.addSuppressed(). However, as far as I can tell, Throwable.addSuppressed() was introduced in JDK 1.7 (Java 7) and therefore the "hack" is only required to support JDK 1.6 (Java 6) or older. But do we still care about JDK 1.6 (Java 6)? I think the oldest JDK that is still maintained is JDK 1.8 (Java 8), which means that JDK 1.7 (Java 7) is obsolete, let alone JDK 1.6 (Java 6).

So, unless JNA still aims to support JDK 1.6 (Java 6), I would like to suggest to just remove Win32Exception.addSuppressedReflected() and use Throwable.addSuppressed() directly, which is a big simplification.

[matthiasblaesing]

Yes, the production builds target JDK 6.

[dEajL3kA]

Then I don't understand why addSuppressedReflected() and addSuppressed() are mixed in the code 🤔

See here for an example where addSuppressed() is called directly:

jna/contrib/platform/src/com/sun/jna/platform/win32/Kernel32Util.java

Line 957 in c32053e

we.addSuppressed(e);

[matthiasblaesing]

"are mixed in the code" is a slight exaggeration. There is exactly one such instance. While being picky, there is also a usage of StandardCharsets in DBT.java. Whether I think this was worth the few hours this took is another matter. #1545