Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

imap2_setflag_full always returns false #21

Open
tnaumann-wecg opened this issue Oct 31, 2022 · 0 comments · May be fixed by #22
Open

imap2_setflag_full always returns false #21

tnaumann-wecg opened this issue Oct 31, 2022 · 0 comments · May be fixed by #22

Comments

@tnaumann-wecg
Copy link

Checking the return result of imap2_setflag_full will always yield the value false, even if the operation was performed successfully.

I tool a quick look and saw that Message::setFlagFull is hardcoded to always return false.
Instead the result of the clients flag call should be returned.

php-imap2/src/Message.php

Lines 457 to 459 in f96973e

$client->flag($imap->getMailboxName(), $sequence, strtoupper(substr($flag, 1)));
return false;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant