Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create new release of silk #187

Closed
albertyw opened this issue Jul 4, 2017 · 25 comments · Fixed by #242
Closed

Create new release of silk #187

albertyw opened this issue Jul 4, 2017 · 25 comments · Fixed by #242
Assignees

Comments

@albertyw
Copy link
Member

albertyw commented Jul 4, 2017

I think once the jazzband migration is complete, it would be a good time to make a new release of silk, either manually or by setting up automatic releases.

@avelis
Copy link
Collaborator

avelis commented Jul 4, 2017

@albertyw Agreed on the new release once the migration is complete. Will look into possibly getting the Travis-CI config file to build on tagged releases.

@avelis
Copy link
Collaborator

avelis commented Aug 3, 2017

@albertyw I have added the config to make releases on tags in the following commit: 53b5ea7

However, since this repo as moved to Jazzband there are some more administrative steps that need to occur.

@albertyw
Copy link
Member Author

Is there an update on this?

@avelis
Copy link
Collaborator

avelis commented Sep 29, 2017

@albertyw I have commented on the need to add jazzband to access the silk pypi project in order to make releases through that account. I am not sure what else I can do but it's part of the requirements. Maybe we should make a release before the migration is completed?

@richardnias
Copy link
Contributor

If there's some difficulty in getting everything in order with pypi and jazzband, my vote would be to make a final release under the existing setup.

@albertyw
Copy link
Member Author

albertyw commented Dec 5, 2017

I'm going to try making a new release now that the pypi permissions issues should be fixed.

@albertyw
Copy link
Member Author

albertyw commented Dec 5, 2017

I'm waiting on #233 before cutting a new release.

@avelis
Copy link
Collaborator

avelis commented Dec 5, 2017

@albertyw The version value is in setup.py. If you want to break that out into a different mechanic that's fine. FYI It is still currently at 1.0.0. If you decide to make a release make sure it gets updated. That has burned me a couple times.

@albertyw
Copy link
Member Author

There's a bug in the travis config. This was in the build output:

Fetching: dpl-1.8.43.gem (100%)
Successfully installed dpl-1.8.43
1 gem installed
invalid option "--password="
failed to deploy

Based on travis-ci/dpl#327, it seems there's a problem with the encrypted password that was added in 53b5ea7. I'm also not sure if we're under the "lead project mamber" system mentioned in jazzband/help#69. I created jazzband/help#82 to have someone follow up.

@avelis
Copy link
Collaborator

avelis commented Dec 28, 2017

@albertyw I added the encrypted password but it was done using deprecated documentation for TravisCI config setup. Looking at the info in jazzband/help#69 it appears a structural change is now in place for reviewing. I guess I missed all this.

Thanks for making jazzband/help#82

@yousifa
Copy link

yousifa commented Jan 5, 2018

Any update on release on pypi?

@avelis
Copy link
Collaborator

avelis commented Jan 5, 2018

@yousifa Not that I know of.

@albertyw albertyw mentioned this issue Jan 7, 2018
@albertyw
Copy link
Member Author

albertyw commented Jan 8, 2018

As an update to everyone here, jazzband/help#82 has been resolved and I've created a temporary branch release-1.1.0 (do not merge into master) to get 1.1.0 on pypi (relevant discussion on 78ad261#commitcomment-26718482). It's currently blocked by jazzband/website#41 but can be retried by rerunning https://travis-ci.org/jazzband/silk/jobs/326440835.

@jezdez
Copy link
Member

jezdez commented Jan 10, 2018

Okay, I've fixed jazzband/website#41 but now the upload fails (correctly) with:

Uploading distributions to https://jazzband.co/projects/silk/upload
Uploading django_silk-1.1.0-py2.py3-none-any.whl
HTTPError: 400 Client Error: The filename for 'silk' must start with 'silk'. for url: https://jazzband.co/projects/silk/upload

The problem is basically that the repo and project are called "silk" while I think you expect things to released to PyPI as "django-silk". I'll go ahead and fix the name of the repo and project on jazzband.co so this won't happen again.

@jezdez
Copy link
Member

jezdez commented Jan 10, 2018

Okay done. Any link to the GitHub project will automatically forward to the new name btw. I've restarted the Travis build to do the release.

@xrmx
Copy link
Contributor

xrmx commented Jan 10, 2018

Build passed but there's HTTPError: 404 Client Error: NOT FOUND for url: https://jazzband.co/projects/silk/upload in the travis logs

@jezdez
Copy link
Member

jezdez commented Jan 10, 2018

Yep, just fixed in de08d5b. Build runs in https://travis-ci.org/jazzband/silk/builds/327171966.

@jezdez
Copy link
Member

jezdez commented Jan 10, 2018

BTW, the gitter.im links didn't seem to work, what's up with that?

@jezdez
Copy link
Member

jezdez commented Jan 10, 2018

Gnaah, apparently Travis-CI didn't handle the repo rename nicely (maybe because GitHub's API is acting up today and the webhook didn't work?), even though I've seen it handle repo renames nicely in the past for other projects. I've just re-enabled travis for the newly named django-silk repo and will restart the build again.

@jezdez
Copy link
Member

jezdez commented Jan 10, 2018

Aha, one of the builds for https://travis-ci.org/jazzband/django-silk/builds/327171966 was still running and apparently released correctly to Jazzband. @avelis you should have gotten an email to confirm the release.

@jezdez
Copy link
Member

jezdez commented Jan 10, 2018

Oh, @albertyw did you want to be able to be lead project member as well as @avelis?

@avelis
Copy link
Collaborator

avelis commented Jan 10, 2018

@jezdez I appreciate all your diligence in getting all the tracks setup for releasing through Jazzband. I did get the confirmation email. I will confirm it later in the morning (currently 5:07am).

Gitter.im was functioning when I took over the repo a year ago but I haven’t been really active on it.

@avelis
Copy link
Collaborator

avelis commented Jan 11, 2018

@jezdez I don't mean to delay this any further but I am getting a 2FA must be setup error.

Sorry, but to release the upload you need to have Two Factor Auth (2FA) enabled on GitHub.

I just set it up again but it's still giving me the error. Am I missing this security setting somewhere else?

@albertyw
Copy link
Member Author

@jezdez Yes, I'd like to be a project lead too. I have 2FA auth set up for my account already so maybe I can get the release to work.

@avelis
Copy link
Collaborator

avelis commented Jan 11, 2018

@jezdez @albertyw Ok, it looks like worked now. Might have been a caching issue on Github's side.
Release 1.1.0 is out.
https://pypi.python.org/pypi/django-silk/1.1.0

@avelis avelis closed this as completed Jan 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants