Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug Report] embedding layer models missing from canonical #316

Open
dribnet opened this issue Oct 3, 2024 · 1 comment
Open

[Bug Report] embedding layer models missing from canonical #316

dribnet opened this issue Oct 3, 2024 · 1 comment

Comments

@dribnet
Copy link

dribnet commented Oct 3, 2024

Was glad to see the embedding SAEs added - 4 to gemma-scope-2b-pt-res and 4 to gemma-scope-9b-pt-res in pretrained_saes.yaml. But I noticed that none of these were elevated to canonical.

Should we promote one of each and add them to gemma-scope-2b-pt-res-canonical and gemma-scope-9b-pt-res-canonical as we do the other layers?
@ShenzheZhu
Copy link

same question, we need canonical embedding layer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dribnet @ShenzheZhu