Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

colap ,pip install zigzag #42

Open
mohvic78 opened this issue Oct 27, 2024 · 12 comments
Open

colap ,pip install zigzag #42

mohvic78 opened this issue Oct 27, 2024 · 12 comments

Comments

@mohvic78
Copy link

error

Collecting zigzag
Using cached zigzag-0.3.2.tar.gz (112 kB)
error: invalid-pyproject-build-system-requires

× Can not process zigzag from https://files.pythonhosted.org/packages/d4/88/028c3d29b17cd2d4cfcc2305bc42e0363d64451e3eda880aab1d0e579069/zigzag-0.3.2.tar.gz
╰─> This package has an invalid build-system.requires key in pyproject.toml.
It contains an invalid requirement: 'Cython>=^0.29'

note: This is an issue with the package mentioned above, not pip.
hint: See PEP 518 for the detailed specification.

@ambroseikpele
Copy link

I created a fork that works:

copy all and paste in a cell (copy also the dot at the end of !pip install and the dot dot at the end of %cd) :

!git clone https://github.com/ambroseikpele/ZigZag
%cd /content/ZigZag
!pip install .
%cd ..

@amirzamli
Copy link

Thanks so much Ambrose! Really awesome work!

@mohvic78
Copy link
Author

mohvic78 commented Nov 1, 2024

Thanks so much

@malakeel
Copy link

@ambroseikpele
Any chance this can make it into official pip packages so that we can use it from a requirements.txt file ?

@AureliusMarcusHu
Copy link

@ambroseikpele,

What do you mean "copy all and paste in a cell", I don't understand what you mean, where in which cell ?
I'm running python 3.10.10 on windows 11 64 bit machine. Which version of Cython we have to install for your fork ?
Please can you explain ?
Thands in advance.

@amirzamli
Copy link

amirzamli commented Nov 23, 2024

@AureliusMarcusHu He means to run the following code within a jupyter notebook cell.

!git clone https://github.com/ambroseikpele/ZigZag
%cd /content/ZigZag
!pip install .
%cd ..

@AureliusMarcusHu
Copy link

AureliusMarcusHu commented Nov 30, 2024

For those who don't have jupyter installed:

pip install "git+https://github.com/ambroseikpele/ZigZag#egg=zigzag"

The install result:
zigzag_install

@AureliusMarcusHu
Copy link

AureliusMarcusHu commented Nov 30, 2024

After installing I run into a dtype mismatch error:

File "C:\fti\pyp\deps\fibonacci_levels.py", line 53, in piv_pnts pivots = peak_valley_pivots(seri.values, poch, -poch) File "zigzag\\core.pyx", line 72, in zigzag.core.peak_valley_pivots File "zigzag\\core.pyx", line 109, in zigzag.core.peak_valley_pivots_detailed ValueError: Buffer dtype mismatch, expected 'int64_t' but got 'long'

I have two computers:
Both have Windows 11 24H2 OS
Both have python 3.10.10 installed.
Both have the same module above installed.

The first one have the original zigzag package installed 3 years ago without zigzag installing error.
On this computer, I don' t have the above error, everything works fine.

The second one has the zigzag fork package installed, because the install error of the original zigzag package.
This computer trow the above error when running the same py module.

There must be some difference in the zigzag package.
Where start to search ? How avoid this error ?

Please help me, I need this package working.
Thanks in advance.

@amirzamli
Copy link

amirzamli commented Nov 30, 2024

@AureliusMarcusHu I have solved this in my fork, i just created a pull request to Ambrose's repo:
ambroseikpele@028031c

Its really simple to fix, just see my changes in the commit i linked.

@ambroseikpele
Copy link

@amirzamli Pull Request merged

@AureliusMarcusHu
Copy link

@AureliusMarcusHu I have solved this in my fork, i just created a pull request to Ambrose's repo: ambroseikpele@028031c

Its really simple to fix, just see my changes in the commit i linked.

@amirzamli
Thanks for the quick reply.

I made the changes manually in core.pyx, but I have still the same error.
Is there anything else I need to do?

@AureliusMarcusHu
Copy link

AureliusMarcusHu commented Dec 2, 2024

@amirzamli and @ambroseikpele

Thanks to all of you, I'm very happy now ... :)
I uninstall zigzag an re-install it again as I write earlier, and now it work as a charme.
What is changed in the mean time ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants