Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LastModifiedCachingWireTest.java:62-69: Clean tests shared fields and... #139

Closed
dmarkov opened this issue Jun 20, 2016 · 1 comment
Closed
Labels

Comments

@dmarkov
Copy link

dmarkov commented Jun 20, 2016

Puzzle 120-e6bf947f in src/test/java/com/jcabi/http/wire/LastModifiedCachingWireTest.java:62-69 has to be resolved: Clean tests shared fields and redundant variables Move constants in this file to their tests because tests must share nothing. Then also inline any redundant variables. Please also configure pdd and est in.travis.yml as done e.g. in https://github.com/jcabi/jcabi-xml/blob/master/.travis.yml For first points explanation, read: http://www.yegor256.com/2016/05/03/test-methods-must-share-nothing.html http://www.yegor256.com/2015/09/01/redundant-variables-are-evil.html... The puzzle was created by Alan Evans on 18-May-2016.

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code.

@dmarkov
Copy link
Author

dmarkov commented Dec 22, 2016

@yegor256 Done, the task is closed

@dmarkov dmarkov closed this as completed Dec 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant