You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The difference between ApacheRequest and JdkRequest is the anonymous inter classes defining initial Wire for the primary connection (by using either JDK or apache-http client), otherwise two classes are the same and just delegate to BaseRequest.
Proposal:
Extract inner Wire implementations as separate classes: JdkWire, ApacheWire
Rename BaseRequest to RequestOn
new RequestOn(new JdkWire(...), url);
Make JdkRequest & etc aliases for new RequestOn(new JdkWire(..), ..)
The difference between
ApacheRequest
andJdkRequest
is the anonymous inter classes defining initialWire
for the primary connection (by using either JDK or apache-http client), otherwise two classes are the same and just delegate toBaseRequest
.Proposal:
Wire
implementations as separate classes:JdkWire
,ApacheWire
BaseRequest
toRequestOn
JdkRequest
& etc aliases fornew RequestOn(new JdkWire(..), ..)
Thus:
TrustedWire
is no longer needed, we can passSSLContext
directly to the initialWire
.Solves: ApacheRequest.java:68-70: TrustedWire does not support... #202 TrustedWire changes SSLSocketFactory globally #178
.through(Class<? extends Wire>)
, can be replaced by a simple and more obvious composition of differentWire
objects, i.eThere is no way to use
Wire
objects like that now.The text was updated successfully, but these errors were encountered: