Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rethink what ITestRunner.Abort should do #111

Open
jcansdale opened this issue May 5, 2018 · 0 comments
Open

Rethink what ITestRunner.Abort should do #111

jcansdale opened this issue May 5, 2018 · 0 comments

Comments

@jcansdale
Copy link
Owner

jcansdale commented May 5, 2018 •
edited
Loading

At the moment it calls Thread.Abort(), leaving the user the option to kill the process via the task tray. Maybe it should simply kill the process, since Thread.Abort() is rarely useful.

For ad hoc, async tests, should it support passing in a CancellationToken arg?

See discussion here: https://github.com/dotnet/corefx/issues/25154#issuecomment-343588083

Related: #136
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jcansdale