Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TDD Assignment #1

Closed
wants to merge 3 commits into from
Closed

TDD Assignment #1

wants to merge 3 commits into from

Conversation

talshi
Copy link

@talshi talshi commented May 9, 2016

@robi-y
Copy link
Contributor

robi-y commented May 11, 2016

Hi,
Did you finish the exercise? please don't send the PR too early.

  1. missing the RED stage commits
  2. implementation passes all tests - which is good - but not complete yet, so you miss more tests.

matanan added a commit to matanan/tdd-nodejs-find-a-person that referenced this pull request May 15, 2016
@ItamarShDev
Copy link
Contributor

also submit when you're done

anisbi added a commit to anisbi/tdd-nodejs-find-a-person that referenced this pull request May 23, 2016
monder93 added a commit to monder93/tdd-nodejs-find-a-person that referenced this pull request May 23, 2016
monder93 added a commit to monder93/tdd-nodejs-find-a-person that referenced this pull request May 23, 2016
@ItamarShDev
Copy link
Contributor

@robi-y

@ItamarShDev ItamarShDev closed this Jun 5, 2016
@robi-y
Copy link
Contributor

robi-y commented Jun 5, 2016

What's the status of this PR?

@ItamarShDev
Copy link
Contributor

invalid
he did a different one and got graded for it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants