Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Theme colours needs better contrast for accessibilty #25

Closed
DanielBaird opened this issue May 10, 2018 · 2 comments
Closed

Theme colours needs better contrast for accessibilty #25

DanielBaird opened this issue May 10, 2018 · 2 comments

Comments

@DanielBaird
Copy link
Member

Trine Paerata reported via Slack that:

the 'text-muted' class that is used on summary cards (byline header) comes up as low contrast for size with a 4.3 ratio (it's just under as ratio needs to be at least 4.5)

..so we should tweak the grey to be a bit darker.

@davidjb
Copy link
Contributor

davidjb commented Jun 8, 2018

So effectively all the colour utils currently in use by the Web Framework need adjustment, but the same is true of core Bootstrap as well (eg https://getbootstrap.com/docs/4.1/utilities/colors/). Reported already at twbs/bootstrap#25126 so we'll follow that in the meantime and adjust the colours when/if Web Framework v2 is released.

@davidjb davidjb changed the title text-muted class needs better contrast Theme colours needs better contrast for accessibilty Jun 8, 2018
@davidjb
Copy link
Contributor

davidjb commented Jul 14, 2021

Closing this out as CookBook v2 has addressed this specific issue in its releases, ensuring that the v2 (Bootstrap v4) builds are being tested for accessibility in common situations in our current documentation. The explanation at https://github.com/jcu/cookbook#accessibility covers other and non-standard ways in which classes can be mixed and matched, and how it is ultimately up to the end designer to ensure accessibility.

@davidjb davidjb closed this as completed Jul 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants