Feedback & feature ideas

[oredaze]

I really like this cute little plugin. I was having a problem with bugs and then found your fork, which fixes it. But you did some changes that are also suboptimal.
Here are my thoughts on feature requests and some of the things that can be improved:

1. It would be very easy to add a hotkey (default "t") to open the buffer in a tab. That would be done with tab sb %s in openOptions.

2. The preview window inherits my vim.opt.relativenumber = true setting, which isn't very useful in a preview. It would be nice if it was sensitive to this and revert to absolute numbers. Or at least give an option to disable numbers.

3. The title, to me, feels like an other entry in the list, at least subconsciously, which is distracting. It would be nice if it could be disabled. Especially now with the new styling of the plugin. Speaking of which:

4. Something happened to the colors in this fork. With certain colorschemes there is a difference between the background of where there are entries and the one where there aren't. It does not look as uniform now... I do have custom highlighting groups set to Pmenu though, but I didn't have a problem with mainline JABS. The title also looks like the entries even more now.

That being said I would like to continue using your fork. I hope you don't drop this project. Or merge with mainline.

[jeff-dh]

1, 2 and 3 should be easy ones. I can probably "fix" them soon.

4. I changed the default color schemes (and just noticed I didn't update the readme) and I think that's the reason of your observations. Try the mainline JABS default values in your config:

    -- Default highlights (must be a valid :highlight)
    highlight = {
        current = "StatusLine", -- default Number
        hidden = "ModeMsg", -- default Statement
        split = "StatusLine", -- default Function
        alternate = "WarningMsg", -- default String
        unlisted = 'Error', -- default ErrorMsg
        filename = 'StatusLine', -- not present in mainline JABS, default nil
    },

[jeff-dh]

Update expJABS, I think 1, 2 and 3 are "fixed".

title -> config disable_title = true
"t" -> tab sb %s
relativenumber should be fixed

[oredaze]

Thank you for the very fast action. That was surprising.

However now JABS doesn't play well with the extension sitiom/nvim-numbertoggle.
When I open JABS (not the preview) my absolute numbers get toggled and the preview still has relative. It works fine without the plugin though, so maybe the issue is on their end.

About the colors: here is a comparison with untouched colors from mainline JABS (top) and expJABS(bottom) with a popular colorscheme gruvbox-material.

As you can see the background is inconsistent between the items and the blank space, and that cannot be changed. The title also looks like an entry, even though I will not be using it other people might.

[jeff-dh]

Concerning the relativenumber issue: I don't know. I just set api.nvim_win_set_option(prev_win, "relativenumber", false), that's all. I've no idea what could be the issue with the other plugin or whose fault it is.
I just noticed I could revert this and you could just set previewConfig.style to "minimal" that would disable the line numbers in the preview window.

And the background issue similiar: I double checked the highlighting calls and they are identical to the mainline JABS calls. I don't have any idea about it at the moment.

If you have any further ideas how to tackle this let me know.

[jeff-dh]

hah!

I just stumble over the background issue while reading your comment again:

    -- hmm for some reason this line is neccessary to assign
    -- the right highlighting to a minimal floating win....
    vim.wo.winhl = 'Normal:Pmenu'

I just removed the line and it seems to be fixed (and I couldn't find any other issue, don't know why I put that line there), update expJABS and I assume your fine.

[oredaze]

Thanks a lot for the excellent work. I will indeed be better off disabling line numbers like you said. I don't want to start bothering more people about this. Please revert it.
The colors are fixed now. 👍

[oredaze]

Umm... I'm sorry to bother you again, but I think the "hidden" icon is lost somehow. You can actually see it in my screenshot too. It is supposed to be the "eye".
Also I noticed the highlight.current customization option does nothing...

I was looking at the code and you are missing

        else
            symbol = symbols.hidden

in utils.lua > function getBufferSymbol

I am actually not a programmer, otherwise I would have done everything myself xD

[jeff-dh]

The hidden issue:

Yeah, that was more or less deliberate, because the hidden flag did not make a lot sense to me. The vim docs say:

		  h	a hidden buffer: It is loaded, but currently not
			   displayed in a window |hidden-buffer|

So all buffers that are not open are hidden. That would mean to put a symbol in front of every file. Furthermore the other flags seemed more important to me and if we would add a hidden symbol we would have to display multiple symbols..... therefor no hidden symbol.

Does that make sense to you? Does the hidden flag is for some reason (more) important to you?

[oredaze]

Yes, that one makes sense.

[jeff-dh]

highlight.current works fine for me:

Adding the following to my config makes the current file red over here

    highlight = {
        current = "Error",
        },

[jeff-dh]

Reverted the relativenumber thing and updated the readme config (removed symbol.hidden).

So I think we sorted everything out, right?

[oredaze]

I figured out why the highlight is not working. It happens only in combination with disable_title = true.
After that I won't bother you anymore.

[oredaze]

Here is how i fixed it:
in jabs.lua add a new variable tfix at line 119 and use it as shown here

        local tfix = config.disable_title and 1 or 0
        api.nvim_buf_set_lines(buf, line_number, - (tfix + 1), true, { line })
        --apply some highlighting
        api.nvim_buf_add_highlight(buf, -1, buf_symbol_hl, new_line - tfix, 0, -1)

Again, I am not a programmer, but this fixes it. You can probably do better.
I am going to close the discussion now, because I have bothered you enough.
Thanks for the help.

[jeff-dh]

Fixed too ;)

Thx for finding all these little issues!

Btw: Concerning "bringing it back to mainline". As you might have noticed I created an issue / discussion in the mainline JABS repo and ask how the two forks could co-exists and there was no reply for several month, so.......
If you want to bring it back to "mainline", I guess you could try to create a pull request for https://github.com/rockerBOO/awesome-neovim and try to make it public in parallel to regular jabs. If you're motivated, go for it.

[oredaze]

I am going to use your fork for now. It satisfies me.