Skip to content
This repository has been archived by the owner on Aug 23, 2024. It is now read-only.

[BUG] Subsonic login api does not work #253

Closed
TLCFEM opened this issue Mar 9, 2022 · 7 comments · Fixed by #257
Closed

[BUG] Subsonic login api does not work #253

TLCFEM opened this issue Mar 9, 2022 · 7 comments · Fixed by #257
Assignees
@jeffvli
Labels
bug Something isn't working
Milestone
Release (0.14.0)

Comments

@TLCFEM
Copy link

TLCFEM commented Mar 9, 2022

Please see the comments in #149 .

/rest/ping.view returns xml.

/rest/ping returns 404.
@TLCFEM TLCFEM added the bug Something isn't working label Mar 9, 2022
@TLCFEM TLCFEM changed the title Subsonic login api does not work [BUG] Subsonic login api does not work Mar 9, 2022
@jeffvli
Copy link
Owner

jeffvli commented Mar 9, 2022

What server are you using?

@TLCFEM
Copy link
Author

TLCFEM commented Mar 9, 2022

I am using the subsonic api shipped with the latest ampache. The test server can be found here. I am not sure if the configuration is correct. But the queries are as follows.

http://104.248.242.221/rest/ping.view?u=guest&p=guest&v=1.13&c=asd

<?xml version="1.0" encoding="UTF-8"?>
<subsonic-response xmlns="http://subsonic.org/restapi" status="ok" version="1.13.0"/>

http://104.248.242.221/rest/ping?u=guest&p=guest&v=1.13&c=asd

<!DOCTYPE HTML PUBLIC"-//IETF//DTD HTML 2.0//EN">
<html><head>
    <title>404 Not Found</title>
  </head><body>
    <h1>Not Found</h1>
    <p>The requested URL was not found on this server.</p>
    <hr>
    <address>Apache/2.4.52 (Debian) Server at 104.248.242.221 Port 80</address>
  </body></html>

@jeffvli
Copy link
Owner

jeffvli commented Mar 9, 2022

Thanks, you're correct that it seems it doesn't work without the .view in the request URL (though all the other servers do work without it). I think I saw some comments in other discussions talking about using .htaccess to remove the .view dependency, but I can probably just refactor it on my side.

@jeffvli jeffvli added this to the Release (0.14.0) milestone Mar 9, 2022
@TLCFEM
Copy link
Author

TLCFEM commented Mar 9, 2022

Yes, this page https://github.com/ampache/ampache/wiki/API also mentions rewrite requests. It appears that .view is there, at least in the regex. Guess an if-else branch should be enough to cover both.

@jeffvli jeffvli moved this from Todo to In Progress in Sonixd (Roadmap and Releases) Mar 10, 2022
@jeffvli jeffvli self-assigned this Mar 10, 2022
@jeffvli jeffvli mentioned this issue Mar 10, 2022
Merged
@jeffvli
Copy link
Owner

jeffvli commented Mar 10, 2022 •
edited
Loading

I packaged a dev build from #257 and uploaded it here: http://ftp.sonixd.com/%28%23253%29%20Sonixd-0.13.1-win.zip. (This is a Windows build, not sure if you're using a different OS).

Can you try installing that version and check if there are any issues? You'll need to check the Legacy Auth checkbox when signing in.

@TLCFEM
Copy link
Author

TLCFEM commented Mar 10, 2022

I compiled it locally and tested login and streaming, it is working smoothly. Thanks for the great project.

@jeffvli
Copy link
Owner

jeffvli commented Mar 10, 2022

Great, thanks for confirming!

Repository owner moved this from In Progress to Done in Sonixd (Roadmap and Releases) Mar 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jeffvli jeffvli

Labels
bug Something isn't working
Projects
Sonixd (Roadmap and Releases)
Status: Done
Milestone
Release (0.14.0)
Development

Successfully merging a pull request may close this issue.

Add ".view" to subsonic API urls (Ampache support) jeffvli/sonixd
2 participants
@TLCFEM @jeffvli