Skip to content
This repository has been archived by the owner on Aug 23, 2024. It is now read-only.

App fonts should be local, not loaded from Google Fonts #284

Closed
poisonborz opened this issue Apr 5, 2022 · 1 comment · Fixed by #295
Closed

App fonts should be local, not loaded from Google Fonts #284

poisonborz opened this issue Apr 5, 2022 · 1 comment · Fixed by #295
Assignees
@jeffvli
Labels
enhancement New feature or request
Milestone
Release (0.15.0)

Comments

@poisonborz
Copy link

poisonborz commented Apr 5, 2022 •
edited
Loading

Problem:
Fonts for the app are loaded from Google Fonts. This might be kinda ok for websites, but bad ux for a desktop app for a number of reasons:

  • What if there is no connection - the app displays broken UI when starting offline.
  • There is no need for a cdn for a static resource used in a desktop app, unlike for a website
  • Bad for privacy, Google will fingerprint each font load and the user's IP address...

Solution:

  • Just provide the fonts from local sources.
@poisonborz poisonborz added the enhancement New feature or request label Apr 5, 2022
@jeffvli
Copy link
Owner

jeffvli commented Apr 6, 2022

Agreed, I'll have to address this.

@jeffvli jeffvli self-assigned this Apr 7, 2022
@jeffvli jeffvli added this to the Release (0.15.0) milestone Apr 10, 2022
@jeffvli jeffvli moved this from Todo to In Progress in Sonixd (Roadmap and Releases) Apr 10, 2022
@jeffvli jeffvli mentioned this issue Apr 11, 2022
Merged
Repository owner moved this from In Progress to Done in Sonixd (Roadmap and Releases) Apr 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jeffvli jeffvli

Labels
enhancement New feature or request
Projects
Sonixd (Roadmap and Releases)
Status: Done
Milestone
Release (0.15.0)
Development

Successfully merging a pull request may close this issue.

Load fonts locally jeffvli/sonixd
2 participants
@poisonborz @jeffvli