Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom On-Screen-Controller for Qt6 #537

Open
sevenrats opened this issue Dec 18, 2023 · 6 comments
Open

Custom On-Screen-Controller for Qt6 #537

sevenrats opened this issue Dec 18, 2023 · 6 comments
Labels
enhancement New feature or request Qt6

Comments

@sevenrats
Copy link
Member

sevenrats commented Dec 18, 2023

Background:
Jellyfin Media Player is blocked from fully porting to Qt6 without additional work because specific behaviors we depend on are bugged in Qt6, namely rendering behind a transparent webview. The Qt6 branch in its current state contains a workaround that moves the video in front of the webapp and shrinks it to reveal the onscreen controller of the webapp. This kinda sorta works but has lots of problems including:

  • settings menu can be partially blocked by the video
  • playback info is broken

In order to make it through the Qt6 era and facilitate native Qt6 support (currently we are ported through the compat api) a custom on-screen-controller must be implemented in QML.

Task:
Build a custom OSC for qt6 that works around https://bugreports.qt.io/browse/QTBUG-111739
this issue will also track other issues which would benefit from the OSC

@sevenrats
Copy link
Member Author

a custom osc would elliminate the roadblocks for mpris
#3

@zjeffer
Copy link

zjeffer commented Dec 31, 2023

Stupid question: what's an OSC? 😄
I've looked around online but can't really find anything. I assume you mean a new overlay to put on top of the video player?

@sevenrats
Copy link
Member Author

good point.

@sevenrats sevenrats changed the title Custom OSC for Qt6 Custom On-Screen-Controller for Qt6 Dec 31, 2023
@sevenrats
Copy link
Member Author

the importance of this is downplayed by the fact that building with the qt5 brew formula work well on m series macs now.

@sevenrats
Copy link
Member Author

#595

@zjeffer
Copy link

zjeffer commented May 18, 2024

Any progress on this? I'd love to help but have very little experience with QML and libmpv.

Is there a plan of action of some kind? What should this new OSC contain, how would it be technically implemented, ...?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Qt6
Projects
Status: No status
Development

No branches or pull requests

2 participants