Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue]: Playback ignores preferred subtitle track #3917

Open
1 task done
Orrielel opened this issue Sep 7, 2022 · 9 comments
Open
1 task done

[Issue]: Playback ignores preferred subtitle track #3917

Orrielel opened this issue Sep 7, 2022 · 9 comments
Labels
bug Something isn't working confirmed The issue has been verified

Comments

@Orrielel
Copy link

Orrielel commented Sep 7, 2022

Please describe your bug

Playback ignores preferred subtitle track, and plays instead first subtitle track.
Happens across multiple users having English set as preferred track, and on different clients.

Sorry for the little details, I just really can't be bothered writing this for the third time after hitting the body character limit.
Really nice the error isn't removable, and the whole issue has to be redone from scratch.
I'm just not a big fan of github. :)

Jellyfin Version

Other

if other:

10.8.4

Environment

- OS: Windows
- Virtualization: No
- Clients: Browser, Jellyfin Media Player, AndroidTV
- Browser: Chrome
- FFmpeg Version: 5.1
- Playback Method: Direct Play and Transcode
- Hardware Acceleration: NVENC
- Plugins: Metadata
- Reverse Proxy: No
- Base URL: No
- Networking: Host
- Storage: Local

Jellyfin logs

No response

FFmpeg logs

No response

Please attach any browser or client logs here

No response

Please attach any screenshots here

image
image

Code of Conduct

  • I agree to follow this project's Code of Conduct
@Orrielel Orrielel added the bug Something isn't working label Sep 7, 2022
@Orrielel

This comment has been minimized.

@Orrielel

This comment has been minimized.

@Orrielel Orrielel changed the title [Issue]: [Issue]: Playback ignores preferred subtitle track Sep 7, 2022
@crobibero crobibero transferred this issue from jellyfin/jellyfin Sep 18, 2022
@jellyfin-bot

This comment has been minimized.

@jellyfin-bot jellyfin-bot added the stale No activity for an extended length of time label Jan 17, 2023
@Orrielel

This comment has been minimized.

@jellyfin-bot jellyfin-bot removed the stale No activity for an extended length of time label Jan 18, 2023
@jellyfin-bot

This comment has been minimized.

@jellyfin-bot jellyfin-bot added the stale No activity for an extended length of time label May 19, 2023
@thornbill thornbill added confirmed The issue has been verified and removed stale No activity for an extended length of time labels May 19, 2023
@dmitrylyzo
Copy link
Contributor

dmitrylyzo commented May 29, 2023

If this problem occurs, check the browser console for messages starting with AutoSet.

UPD:
Is User settings / Playback / Set subtitle track based on previous item enabled?
playback

If so, since RememberSubtitleSelections is true, it remembers the selected track.

We probably messed up with its logic. Initially it controls the saving of the track selection for each item. Currently we also use it to auto set the track selection for the next item in the play queue.

@AbandonedCart
Copy link

If this problem occurs, check the browser console for messages starting with AutoSet.

UPD: Is User settings / Playback / Set subtitle track based on previous item enabled? playback

If so, since RememberSubtitleSelections is true, it remembers the selected track.

We probably messed up with its logic. Initially it controls the saving of the track selection for each item. Currently we also use it to auto set the track selection for the next item in the play queue.

It’s funny you would mention that, since I was searching for similar issues before reporting one myself. The feature you are citing here appears to be broken. I have both options selected. On a video where the first (default) audio track is Japanese audio and English subtitles are enabled by default, I launch the video and set the audio to English and subtitles off.

Everything is fine with the video currently playing, even if I leave and return to it later. When the next video plays, it’s back to Japanese audio and English subtitles. There is a catch, though. The UI has English audio and no subtitles selected. Ironically, the only way to fix it is to select the items it is actually playing and then select the desired options again.

The last client I tested this with was the latest release of 10.9.11, so I cannot yet confirm if it behaves in 10.10

@dmitrylyzo
Copy link
Contributor

When the next video plays, it’s back to Japanese audio and English subtitles. There is a catch, though. The UI has English audio and no subtitles selected.

This behaviour is fixed by #6112 (10.10).

@AbandonedCart
Copy link

AbandonedCart commented Oct 20, 2024

This behaviour is fixed by #6112 (10.10).

Alright. It seemed like the two may be related, since the outcome was essentially the same (reverting to the first / default tracks). I’ll give that a try to confirm Initial testing appears like it does fix the issue. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working confirmed The issue has been verified
Projects
None yet
Development

No branches or pull requests

5 participants