Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] Unintentional wrap of button label for "SaveChanges" (multiple languages) #6211

Open
bluemoehre opened this issue Oct 16, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@bluemoehre
Copy link
Contributor

bluemoehre commented Oct 16, 2024

Describe The Bug

The label of the save button breaks into multiple lines. This unnecessarily affects the layout and wastes space on mobile screens.
It happens with several languages if the label has multiple words and exceeds ~16 chars.

All related project files (59)

(This is an UI/UX issue only - no functional problems detected yet)

Steps To Reproduce

  1. Change UI language to eg. DE | FR | HU | RO
  2. Go to Overview
  3. Open any item's menu
  4. Select Edit Metadata

Expected Behavior

Button label should not break into multiple lines. This can be achieved by using shorter text, enlarging the buttons or allow them to grow.

At least for DE, EN, ES, FR I can say that a single word like "Save" or "Apply" is absolutely common.
I am sure it's the same with more languages, so I would recommend updating the translations.

EDIT: I found there is already a short version Save in most languages. I am not sure why this is mixed.

Screenshots

Screenshot

System (please complete the following information):

  • Platform: all
  • Browser: all
  • Jellyfin Version: 10.9.11

Additional Context

I've already checked the CSS, and if we prefer changes here, it's also possible. Just a slightly higher risk of breaking something elsewhere.

@tylers-username
Copy link
Contributor

MR: #6250

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants