Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Solution Included] Add package.json to tutorial & Add SOURCE_BRANCH variable #25

Open
Maxlinn opened this issue Apr 2, 2022 · 1 comment

Comments

@Maxlinn
Copy link

Maxlinn commented Apr 2, 2022

Hi there, thanks for bringing us this amazing script, credits to your work.
During deployment, i encountered few problems and solved them. However, i know little about frontend so cannot help with the code directly, but i can still bring out some hints.

Lack of package.json

Describe the bug

When following the instruction of tutorial, error occurs that "no package.json found".

Solution

I followed this Example Repository to add an identitcal package.json file to the root of my repo, then it solved.

Default branch no longer names master now

Describe the bug

After solving the first one, error still ocurrs that master branch does not exists.

Solution

Nowadays github no longer uses master as default branch, main instead.
The environment variables of this script does not provide one to specify the source branch.
As a workaround for now, i changed my repository's default branch name from main to master, then it solved.

@Maxlinn Maxlinn changed the title [Solution Included] Add package.json to tutorial & Add SOURCE_BRANCH varaiable [Solution Included] Add package.json to tutorial & Add SOURCE_BRANCH variable Apr 2, 2022
@jenkey2011
Copy link
Owner

Thanks @Maxlinn
It would be better to update to README ~ 🤣

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants