Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[help] Failed pipeline should not decline the PR and just report on the PR #195

Closed
91pratyush opened this issue Sep 14, 2021 · 6 comments
Closed

Comments

@91pratyush
Copy link

Currently the failed pipeline declines the PR. After that the developer has to make changes, push commit and raise the PR again. Is there any way to ensure that the failed pipeline's status is just posted on the PR and does not decline the PR?

@91pratyush
Copy link
Author

Closing as I had enabled the Allow Jenkins to approve PR option

@y0zg
Copy link

y0zg commented Nov 6, 2021

@KumarPratyush hi, can you please provide more details on your workaround? I need to prevent PR to be declined whenever Jenkins job is failed. Where is this option available? Allow Jenkins to approve PR

@91pratyush
Copy link
Author

This option comes in the configure page of any job.
image

@y0zg
Copy link

y0zg commented Nov 10, 2021

@KumarPratyush That's correct, so in your case Jenkins doesn't approve any PRs, am I correct?
Asking as I have the same issue and I need only Jenkins approval for PRs but not PRs decline #199

@91pratyush
Copy link
Author

As mentioned in #199 , they both work in tandem. If you select this check box, it will decline for failure and approve for success.

@y0zg
Copy link

y0zg commented Nov 11, 2021

Yep, I wonder if you approve PRs within CICD pipelines in different manner

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants