From 619f52aa09dcbe930e289619fc44a71ac5d96166 Mon Sep 17 00:00:00 2001
From: Yaroslav <91559310+yaroslavafenkin@users.noreply.github.com>
Date: Mon, 16 Dec 2024 14:27:21 +0200
Subject: [PATCH] [JENKINS-74110][JENKINS-74109] Extract inline JavaScript
 (#335)

* [JENKINS-74109] Extract inline JavaScript from `AbstractClaimBuildAction/summary.jelly`

* [JENKINS-74109] Extract JavaScript from `AbstractClaimBuildAction/tablerow.jelly`
---
 .../AbstractClaimBuildAction/resource.js      | 42 +++++++++++++++
 .../AbstractClaimBuildAction/summary.jelly    | 31 +++--------
 .../tablerow-resource.js                      | 53 +++++++++++++++++++
 .../AbstractClaimBuildAction/tablerow.jelly   | 42 +++------------
 4 files changed, 109 insertions(+), 59 deletions(-)
 create mode 100644 src/main/resources/hudson/plugins/claim/AbstractClaimBuildAction/resource.js
 create mode 100644 src/main/resources/hudson/plugins/claim/AbstractClaimBuildAction/tablerow-resource.js

diff --git a/src/main/resources/hudson/plugins/claim/AbstractClaimBuildAction/resource.js b/src/main/resources/hudson/plugins/claim/AbstractClaimBuildAction/resource.js
new file mode 100644
index 00000000..27105a0c
--- /dev/null
+++ b/src/main/resources/hudson/plugins/claim/AbstractClaimBuildAction/resource.js
@@ -0,0 +1,42 @@
+function showPopup() {
+    var hp = document.getElementById("claimHoverPopup");
+    hp.style.display = "block";
+}
+
+function hidePopup() {
+    var hp = document.getElementById("claimHoverPopup");
+    hp.style.display = "none";
+}
+
+function display(error) {
+    var reasonText = document.getElementById("errordesc");
+    claimBuildAction.getReason(error, function(content) {
+        reasonText.textContent = content.responseObject();
+    });
+}
+
+Behaviour.specify("A#claim", "AbstractClaimBuildAction_claim", 0, function (element) {
+    element.addEventListener("click", (event) => {
+        event.preventDefault();
+        showPopup();
+    });
+});
+
+Behaviour.specify("A#reassign", "AbstractClaimBuildAction_reassign", 0, function (element) {
+    element.addEventListener("click", (event) => {
+        event.preventDefault();
+        showPopup();
+    });
+});
+
+Behaviour.specify(".claim-hide-popup", "AbstractClaimBuildAction_hide-popup", 0, function (element) {
+    element.addEventListener("click", (event) => {
+        hidePopup();
+    });
+});
+
+Behaviour.specify(".claim-bfa-display-error", "AbstractClaimBuildAction_display-bfa-error", 0, function (element) {
+    element.addEventListener("change", (event) => {
+        display(event.target.value);
+    });
+});
diff --git a/src/main/resources/hudson/plugins/claim/AbstractClaimBuildAction/summary.jelly b/src/main/resources/hudson/plugins/claim/AbstractClaimBuildAction/summary.jelly
index 755f3380..f4651526 100644
--- a/src/main/resources/hudson/plugins/claim/AbstractClaimBuildAction/summary.jelly
+++ b/src/main/resources/hudson/plugins/claim/AbstractClaimBuildAction/summary.jelly
@@ -1,26 +1,8 @@
 <?jelly escape-by-default='true'?>
 <j:jelly xmlns:j="jelly:core" xmlns:st="jelly:stapler" xmlns:t="/lib/hudson" xmlns:f="/lib/form">
 
-    <script type="text/javascript">
-        function ShowPopup(hoveritem) {
-            var hp = document.getElementById("claimHoverPopup");
-            hp.style.display = "block";
-        }
-
-        function HidePopup() {
-            var hp = document.getElementById("claimHoverPopup");
-            hp.style.display = "none";
-            var action = <st:bind value="${it}" />;
-        }
-
-        function Display(error) {
-            var reasonText = document.getElementById("errordesc");
-            var action = <st:bind value="${it}" />;
-            action.getReason(error, function(content) {
-                reasonText.textContent = content.responseObject();
-            });
-        }
-   </script>
+    <st:bind var="claimBuildAction" value="${it}"/>
+    <st:adjunct includes="hudson.plugins.claim.AbstractClaimBuildAction.resource"/>
 
     <t:summary icon="symbol-solid/user-doctor plugin-font-awesome-api">
         <p>
@@ -30,7 +12,7 @@
             <j:set var="linkWritten" value="false"/>
             <j:if test="${it.canClaim()}">
                 <j:if test="${linkWritten}"><st:nbsp/></j:if>
-                <a id="claim" href="#" onClick="ShowPopup(this); return false;">
+                <a id="claim" href="#">
                     <j:out value="${it.messageProvider.getClaimActionText()}"/>
                 </a>
                 <j:set var="linkWritten" value="true"/>
@@ -44,7 +26,7 @@
             </j:if>
             <j:if test="${it.canReassign()}">
                 <j:if test="${linkWritten}"><st:nbsp/></j:if>
-                <a id="reassign" href="#" onClick="ShowPopup(this); return false;">
+                <a id="reassign" href="#">
                     <j:out value="${it.messageProvider.getReassignActionText()}"/>
                 </a>
                 <j:set var="linkWritten" value="true"/>
@@ -67,7 +49,7 @@
                     </f:entry>
                     <j:if test="${it.isBFAEnabled()}">
                         <f:entry title="${%Error}" field="errors" help="/plugin/claim/help-errors.html">
-                            <f:select onChange="Display(this.value);"/>
+                            <f:select clazz="claim-bfa-display-error"/>
                         </f:entry>
                         <f:entry title="${%Description}" help="/plugin/claim/help-description.html">
                           <f:textarea name="errordesc" id="errordesc" value="${it.getReason(it.error)}" readonly="true"/>
@@ -85,7 +67,8 @@
                     <f:block>
                         <div class="jenkins-buttons-row jenkins-buttons-row--equal-width" style="justify-content: right;">
                             <f:submit value="${%Claim}"/>
-                            <button type="button" name="Cancel" formNoValidate="formNoValidate" class="jenkins-button jenkins-submit-button}" onClick="HidePopup();">
+                            <button type="button" name="Cancel" formNoValidate="formNoValidate" 
+                                    class="jenkins-button jenkins-submit-button claim-hide-popup">
                                 ${%Cancel}
                             </button>
                         </div>
diff --git a/src/main/resources/hudson/plugins/claim/AbstractClaimBuildAction/tablerow-resource.js b/src/main/resources/hudson/plugins/claim/AbstractClaimBuildAction/tablerow-resource.js
new file mode 100644
index 00000000..869c2957
--- /dev/null
+++ b/src/main/resources/hudson/plugins/claim/AbstractClaimBuildAction/tablerow-resource.js
@@ -0,0 +1,53 @@
+function showPopup(hoveritem) {
+    var row = hoveritem.closest('tr');
+    var hp = row.querySelector(".claimHoverPopup");
+    if (hp) {
+        hp.style.display = "block";
+    } else {
+        console.error("Claim popup not found in the same row.");
+    }
+}
+
+function hidePopup(hoveritem) {
+    var row = hoveritem.closest('tr');
+    var hp = row.querySelector(".claimHoverPopup");
+    if (hp) {
+        hp.style.display = "none";
+    } else {
+        console.error("Claim popup not found in the same row.");
+    }
+}
+
+function display(hoveritem, error) {
+    var row = hoveritem.closest('tr');
+    var reasonText = row.querySelector('#errordesc');
+    claimBuildAction.getReason(error, function(content) {
+        reasonText.textContent = content.responseObject();
+    });
+}
+
+Behaviour.specify("A#claim", "AbstractClaimBuildAction_claim", 0, function (element) {
+    element.addEventListener("click", (event) => {
+        event.preventDefault();
+        showPopup(event.target.closest("a#claim"));
+    });
+});
+
+Behaviour.specify("A#reassign", "AbstractClaimBuildAction_reassign", 0, function (element) {
+    element.addEventListener("click", (event) => {
+        event.preventDefault();
+        showPopup(event.target.closest("a#reassign"));
+    });
+});
+
+Behaviour.specify(".claim-hide-popup", "AbstractClaimBuildAction_hide-popup", 0, function (element) {
+    element.addEventListener("click", (event) => {
+        hidePopup(event.target);
+    });
+});
+
+Behaviour.specify(".claim-bfa-display-error", "AbstractClaimBuildAction_display-bfa-error", 0, function (element) {
+    element.addEventListener("change", (event) => {
+        display(event.target, event.target.value);
+    });
+});
\ No newline at end of file
diff --git a/src/main/resources/hudson/plugins/claim/AbstractClaimBuildAction/tablerow.jelly b/src/main/resources/hudson/plugins/claim/AbstractClaimBuildAction/tablerow.jelly
index 4e173343..4f47a240 100644
--- a/src/main/resources/hudson/plugins/claim/AbstractClaimBuildAction/tablerow.jelly
+++ b/src/main/resources/hudson/plugins/claim/AbstractClaimBuildAction/tablerow.jelly
@@ -2,42 +2,13 @@
 <j:jelly xmlns:j="jelly:core" xmlns:st="jelly:stapler" xmlns:f="/lib/form">
     <j:if test="${it.isColumnDisplayed()}">
         <td class="pane">
-            <script type="text/javascript">
-                function ShowPopup(hoveritem) {
-                var row = hoveritem.closest('tr');
-                var hp = row.querySelector(".claimHoverPopup");
-                if (hp) {
-                    hp.style.display = "block";
-                } else {
-                    console.error("Claim popup not found in the same row.");
-                }
-                }
-
-                function HidePopup(hoveritem) {
-                var row = hoveritem.closest('tr');
-                var hp = row.querySelector(".claimHoverPopup");
-                if (hp) {
-                hp.style.display = "none";
-                } else {
-                console.error("Claim popup not found in the same row.");
-                }
-                var action = <st:bind value="${it}" />;
-                }
-
-                function Display(hoveritem, error) {
-                var row = hoveritem.closest('tr');
-                var reasonText = row.querySelector('#errordesc');
-                var action = <st:bind value="${it}" />;
-                action.getReason(error, function(content) {
-                reasonText.textContent = content.responseObject();
-                });
-                }
-            </script>
+            <st:bind var="claimBuildAction" value="${it}"/>
+            <st:adjunct includes="hudson.plugins.claim.AbstractClaimBuildAction.tablerow-resource"/>
 
             <j:set var="linkWritten" value="false"/>
             <j:if test="${it.canClaim()}">
                 <j:if test="${linkWritten}"><st:nbsp/></j:if>
-                <a id="claim" href="#" onClick="ShowPopup(this); return false;">
+                <a id="claim" href="#">
                     <j:out value="${it.messageProvider.getClaimActionText()}"/>
                 </a>
                 <j:set var="linkWritten" value="true"/>
@@ -51,7 +22,7 @@
             </j:if>
             <j:if test="${it.canReassign()}">
                 <j:if test="${linkWritten}"><st:nbsp/></j:if>
-                <a id="reassign" href="#" onClick="ShowPopup(this); return false;">
+                <a id="reassign" href="#">
                     <j:out value="${it.messageProvider.getReassignActionText()}"/>
                 </a>
                 <j:set var="linkWritten" value="true"/>
@@ -65,7 +36,7 @@
                         </f:entry>
                         <j:if test="${it.isBFAEnabled()}">
                             <f:entry title="${%Error}" field="errors" help="/plugin/claim/help-errors.html">
-                                <f:select onChange="Display(this, this.value);"/>
+                                <f:select clazz="claim-bfa-display-error"/>
                             </f:entry>
                             <f:entry title="${%Description}" help="/plugin/claim/help-description.html">
                                 <f:textarea name="errordesc" id="errordesc" value="${it.getReason(it.error)}" readonly="true"/>
@@ -83,7 +54,8 @@
                         <f:block>
                             <div class="jenkins-buttons-row jenkins-buttons-row--equal-width" style="justify-content: right;">
                                 <f:submit value="${%Claim}"/>
-                                <button type="button"  name="Cancel" formNoValidate="formNoValidate" class="jenkins-button jenkins-submit-button}" onClick="HidePopup(this);">
+                                <button type="button"  name="Cancel" formNoValidate="formNoValidate" 
+                                        class="jenkins-button jenkins-submit-button claim-hide-popup">
                                     ${%Cancel}
                                 </button>
                             </div>