Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple json files management #58

Closed
totocaca123 opened this issue Sep 10, 2022 · 5 comments
Closed

Multiple json files management #58

totocaca123 opened this issue Sep 10, 2022 · 5 comments
Labels
enhancement Enhancement of existing functionality

Comments

@totocaca123
Copy link
Collaborator

totocaca123 commented Sep 10, 2022

What feature do you want to see added?

It's not a feature request but an open question:

  • if we have multiple json files, multiple diagrams will be created (1 file = 1 report).

If we define same id and same report name in json file, all data are not merged and the plugin create multiple reports

How to force inside json file to indicate the right data set.
For example if I have 10 json files:

  • File 1 to 4 go to report 1
  • File 5 to 10 go to report 2
    In the current design, 10 reports will be created
    image

So for multiple file I see many options:

  • Generate only 1 report (merging all data) but json files needs to be similar in columns
  • Merge all files with same Id/Same report name? (json must be compatible each others or define 0 for undefined columns)

Upstream changes

No response

@totocaca123 totocaca123 added the enhancement Enhancement of existing functionality label Sep 10, 2022
@simonsymhoven
Copy link
Member

@totocaca123 Thanks for your effort and all the feedback! I appreciate it very much! Feel free to help with the development. I don't have too much time to spend on this :)

@simonsymhoven
Copy link
Member

At the moment each json have to have a unique id.

@totocaca123
Copy link
Collaborator Author

totocaca123 commented Sep 10, 2022

@totocaca123 Thanks for your effort and all the feedback! I appreciate it very much! Feel free to help with the development. I don't have too much time to spend on this :)

I'm available but my skills is quiet limited. I can work en file format, file examples, and minor features (could take few easy tasks).
Moreover, I find this plugin very interesting (similar to warning next generation). I tried to use warning plugin with csv to get the beautifull views, but it is impossible.
This plugin is similar to plot, but with a much more better interface. If the csv support (simply), this plugin could get lot of success (more installs and more coder)

@totocaca123
Copy link
Collaborator Author

At the moment each json have to have a unique id.

I tested (I copy/paste the example files). All my files have same ID and same report name. The plugin generates 1 report per file. So it seems that unique ID/report name is not corretly handled

@simonsymhoven
Copy link
Member

At the moment each json have to have a unique id.

I tested (I copy/paste the example files). All my files have same ID and same report name. The plugin generates 1 report per file. So it seems that unique ID/report name is not corretly handled

That's true, I have to make sure, that each report has a unique id, otherwise the logic of this plugin won't work correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement of existing functionality
Projects
None yet
Development

No branches or pull requests

2 participants