Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spotless check is run in quick-build #748

Closed
jtnord opened this issue Apr 28, 2023 · 0 comments · Fixed by #752
Closed

spotless check is run in quick-build #748

jtnord opened this issue Apr 28, 2023 · 0 comments · Fixed by #752
Labels

Comments

@jtnord
Copy link
Member

jtnord commented Apr 28, 2023

Jenkins and plugins versions report

`mvn verify -Pquick-build` still runs spotless
Apache Maven 3.9.1 (2e178502fcdbffc201671fb2537d0cb4b4cc58f8)
Maven home: c:\java\maven-3.9.1
Java version: 11.0.15, vendor: Eclipse Adoptium, runtime: c:\java\jdk-11.0.15+10
Default locale: en_GB, platform encoding: Cp1252
OS name: "windows 11", version: "10.0", arch: "amd64", family: "windows"

due to the activation of spotless in children of the the quick-build profile setting of spotless.check.skip is ignored as the child modules opting into spotless override this behaviour.

Observed in plugin-compat-tester

What Operating System are you using (both controller, and any agents involved in the problem)?

Windows

Reproduction steps

  1. introduce some violation in a downstream plugin of this project that has spotless enabled (e.g. insert some extra tabs instead of spaces in java source code of https://github.com/jenkinsci/plugin-compat-tester)
  2. run mvn -Pquick-build verify

Expected Results

the build completes and a jar file exists in target

Actual Results

the build fails as spotless has detected errors

Anything else?

see jenkinsci/pom#425 for exactly the same issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant