make private classes private, dont pass params

[jlambert121]

It is very difficult to test at the subclass level to ensure parameters set at the main class are passed correctly to the subclass, especially when the subclass has defaults of it's own. I have made the mistake numerous times of setting a subclass parameter and all of the tests succeed but I forgot to actually pass the value from the main class.

This PR removes parameter passing and pulls all variables directly from the main class.
Spec tests are updated to ensure subclasses behave as they should based on parameters to the main class
OS dependent testing removed from main spec, no OS dependent decisions are made there
Minor bug fixes
Minor lint cleanup

[jenkinsadmin]

Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests

[rtyler]

Can you remove the commit that removes this file from the PR?

[jlambert121]

Thoughts on how we get complete testing for all versions of puppet then? The Gemfile.lock pins puppet to 3.(something) currently which means traivs can't test 2.7 or the other versions of puppet in the 3 branch.

[rtyler]

That can (AFAIK) be accomplished by using multiple Gemfiles and referencing them in the .travis.yml. I included the Gemfile.lock to keep some of our development environments synchronized.

[jlambert121]

I'll back this commit out. I'm not familiar with what you're suggesting though so I'll leave that one to you. :)

[rtyler]

Overall I think I get what you're going for and I'm cool with it. Did your editor automatically futz with a bunch of resources though? Moving the name up a line from:

package {
  'my-package' :
    version => latest;
}

to

package { 'my-package' :
    version => latest;
}

[jlambert121]

Nope, the change from

package {
  'my-package':
    version => latest;
}

to

package { 'my-package':
  version => latest;
}

was me standardizing the way we name resources - we have it both ways. The style guid seems to prefer the latter so that's what I went with.

[rtyler]

[matthewbarr]

We need to document these options. They aren't in the current parameters list at the top of file.