Fixes to Jenkins slave init and class

[lcrisci]

No description provided.

[jenkinsadmin]

Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests

[cfeskens]

+1 to merge this. This would save my puppet runs from trying to restart my jenkins slaves every 30 minutes.

[mark0n]

Can you make it . /lib/lsb/init-functions to be a bit more LSB compliant? See http://refspecs.linuxfoundation.org/LSB_4.1.0/LSB-Core-generic/LSB-Core-generic/iniscrptfunc.html for details.

[cfeskens]

I tried using /lib/lsb/init-functions, and it doesn't work on RHEL systems. /lib/lsb/init-functions doesn't seem to include the status function used by slave_status(). In most cases, scripts listed in /lib/lsb/init-functions turn around and source /etc/init.d/functions.

Would you prefer using /etc/init.d/functions for it's 'status' command or modifying slave_status() in /etc/init.d/jenkins-slave to not call 'status -p'?

[lcrisci]

The existing scripts under /etc/init.d/ on a RHEL6 system ( the ones that we are using here ) are not using any functions sourced from /lib/lsb/init-functions.

This file is also missing a function such as "checkpid" which is being sourced from the regular /etc/rc.d/init.d/functions.

We would need to change the functions inside the init script itself and i don't see it as a necessity for now.Easier to source /etc/rc.d/init.d/functions like what is happening with the other scripts.

[rtyler]

I think with the merging of #171 we cover this case. Please reopen this if that's not the case