fixes timeouts on restart #233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
endyman
force-pushed
the
fix/user_timeouts_on_restart
branch
from
806cc7c to
9232e56
Compare
endyman
force-pushed
the
fix/user_timeouts_on_restart
branch
from
9232e56 to
67476a2
Compare
|
travis issues are caused by bundler not by this PR |
|
Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests |
|
I think increasing the timeouts is okay, but there's a lot of repetition of hard-coded timeouts and tries here, can you refactor those values into |
increased timeouts added timouts to security and increased credential timeouts moved retry values into param
endyman
force-pushed
the
fix/user_timeouts_on_restart
branch
from
67476a2 to
21dd8b5
Compare
|
done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Puppet modules fails while modifying users, credentials or security when the server is not yet up. This PR implements timeouts.