Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi There,
Thanks for your hard work on this package. I've developed a PR you may be interested in which adds support for directly downloading the RPM package from a regular HTTP server.
This is useful for places that both don't have their own yum repository or access to download from the Internet.
The PR works by adding a new parameter to the
jenkins
class calleddirect_download
which the user can use to specify the whole remote path to the package file which can then be downloaded and installed.I've also fully documented this, added an RSpec test class, added this new class into the anchors your using and fixed the metadata.json file (there were invalid version numbers and I'm using
nanlui/staging
to download remote files).Hope this can be merged if at all possible.
Thanks,
Geoff