Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Direct package #256

Merged
merged 6 commits into from
Apr 26, 2015
Merged

Direct package #256

merged 6 commits into from
Apr 26, 2015

Conversation

GeoffWilliams
Copy link
Contributor

Hi There,

Thanks for your hard work on this package. I've developed a PR you may be interested in which adds support for directly downloading the RPM package from a regular HTTP server.

This is useful for places that both don't have their own yum repository or access to download from the Internet.

The PR works by adding a new parameter to the jenkins class called direct_download which the user can use to specify the whole remote path to the package file which can then be downloaded and installed.

I've also fully documented this, added an RSpec test class, added this new class into the anchors your using and fixed the metadata.json file (there were invalid version numbers and I'm using nanlui/staging to download remote files).

Hope this can be merged if at all possible.

Thanks,
Geoff

@jenkinsadmin
Copy link

Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests

@rtyler rtyler added this to the 1.4.0 - Smithers milestone Apr 26, 2015
rtyler pushed a commit that referenced this pull request Apr 26, 2015
@rtyler rtyler merged commit 4ac5106 into voxpupuli:master Apr 26, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants