Apt upgrade #301
Apt upgrade #301
Conversation
PuppetLabs launched the 2.1.0 branch last month. Although it is a "major" upgrade, none of the major changes are relevant to this module (which only takes advantage of the apt::source object type). This update allows this module to run with either the old and new version of the apt module, rather than forcing a specific version.
Users of this module should select which version of the apt-module they're using with the "apt_version" parameter. This parameter is set to "1" for backwards compatability- users who update this module should not see any issues. However, in the future (presumably 2.0 if semver is being used) it may make sense to switch this to 2.
|
Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests |
|
@tedivm I'm generally not enthusiastic about trying to maintain support for multiple APIs; why not just upgrade to 2.x? |
|
I'm mostly just trying to be accommodating- I can rip that code out, I'd just like to see support for the latest apt module. |
|
Would you guys prefer I remove the support for multiple versions? @rtyler? |
|
|
||
|
|
||
|
|
||
|
|
There was a problem hiding this comment.
No idea honestly. It's been removed.
|
+1 for this. It's really annoying to have to pin the apt dependency to a past release. :) Thanks for the work guys, love the module. |
| key => '150FDE3F7787E7D11EF4E12A9B7D32F2D50582E6', | ||
| key_source => 'http://pkg.jenkins-ci.org/debian/jenkins-ci.org.key', | ||
| include_src => false, | ||
| if $::jenkins::apt_version = 2 { |
|
I am not quite sure, if this is due to the version of puppet that my jenkins is running (3.7.5), but it barfs on those assignments. I that legal with the new parser? Anyway, from a stylistic point: -1 from me. |
| @@ -20,7 +20,7 @@ | |||
| ], | |||
| "dependencies": [ | |||
| { "name": "puppetlabs/stdlib", "version_requirement": ">= 4.6.0 < 5.0.0" }, | |||
| { "name": "puppetlabs/apt", "version_requirement": ">= 0.0.3 < 2.0.0" }, | |||
| { "name": "puppetlabs/apt", "version_requirement": ">= 0.0.3 < 3.0.0" }, | |||
There was a problem hiding this comment.
I think this should be either >= 1.0.0 < 3.0.0 or >= 2.0.0 < 3.0.0 if we can drop support for the apt 1.x API.
|
We're experiencing this issue as well, where other modules have a dependency on |
|
Perhaps I should look at the PR properly, and the changes required :) However it's implemented, any change to puppetlabs-apt > 2.x would be greatly appreciated, hope this get's merged soon. |
|
I'd suggest holding off at this point. The puppetlabs team is working on an apt v2.1 that actually adds more backwards compatibility and will reduce the amount of changes needed to support both >v2 and <v2.1. Once they finish that there's a good chance that the only change needed here will be on the dependency metadata itself. |
|
I'm closing this ticket out in favor of #323. |
PuppetLabs launched the 2.1.0 branch last month. This update allows this module to run with either the old and new version of the apt module, rather than forcing a specific version.
This is similar to #281, however it also updates the metadata files and provides backwards compatibility.