Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make spacer display responsive in the menu #522

Open
lillastormen opened this issue Oct 7, 2024 · 3 comments
Open

Make spacer display responsive in the menu #522

lillastormen opened this issue Oct 7, 2024 · 3 comments
Assignees

Comments

@lillastormen
Copy link

I noticed that there is a spacer in the menu, which creates scroll bar when it's not needed for certain window heights. The spacer is likely there to prevent navigation buttons to cover the content of the menu on smaller screens. I'd want to suggest hiding the spacer for the menu for screens wider than 1k pixels.

@jeremyckahn
Copy link
Owner

Hi @lillastormen, I think I know what you're talking about, but would you mind posting some screenshots to make sure we're talking about the same thing?

@lillastormen
Copy link
Author

lillastormen commented Oct 8, 2024

Hi @jeremyckahn,

here's the spacer in question:
Screenshot 2024-10-08 at 23 20 15

As you can see it creates a scroll bar when it's not needed. My idea was that maybe hiding it, when it's not needed, could create a bit cleaner interface :)

And here's the screenshot, where the spacer is removed:

Screenshot 2024-10-08 at 23 30 03

@jeremyckahn
Copy link
Owner

Got it! Thanks for clarifying, @lillastormen. As you deduced, that spacer is there to make sure that the navigation buttons at the bottom don't obscure any content on mobile devices:

Screenshot of Farmhand on a small screen

I agree that it would be worth hiding the spacer on larger screens where it's not necessary. Good thinking @lillastormen! Feel free to open a PR. 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants