Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Typing for multiValueHeaders should be array #274

Closed
jrgermain opened this issue Sep 26, 2024 · 0 comments · Fixed by #273
Closed

[Bug] Typing for multiValueHeaders should be array #274

jrgermain opened this issue Sep 26, 2024 · 0 comments · Fixed by #273

Comments

@jrgermain
Copy link
Contributor

jrgermain commented Sep 26, 2024 •
edited
Loading

I noticed that the TypeScript type definition for a Request types the multiValueHeaders property as an object whose values are strings. Based on the structure of the API Gateway event and the code in this library, it looks like this should be string[] instead of string.

I opened PR #273 to update the type definition to match the actual behavior.

Let me know if there’s anything else I can do to help!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Correct type of multiValueHeaders jrgermain/lambda-api
1 participant
@jrgermain