Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

readable stream does not emit 'end' event #104

Closed
chunseoklee opened this issue Jun 25, 2015 · 4 comments
Closed

readable stream does not emit 'end' event #104

chunseoklee opened this issue Jun 25, 2015 · 4 comments

Comments

@chunseoklee
Copy link
Contributor

After applying daf7b02 commit,
readable stream does not emit 'end' event after pushing null into stream.

@chunseoklee
Copy link
Contributor Author

Readable.prototype.resume = function() {
  console.log("resume");
  var state = this._readableState;
  if (!state.flowing) {
    state.flowing = true;
    if (state.length > 0) {
      console.log("emitData");
      emitData(this, readBuffer(this));
    }
    var self = this;
    process.nextTick(function() {
      self.read(0);
    });
  }
  return this;
};

code above seems to work fine in my http test, but i am not 100% sure for the correctness.

@ILyoan
Copy link
Contributor

ILyoan commented Jun 29, 2015

@chunseoklee #106 landed, could you check if this problem is fixed?

@ILyoan
Copy link
Contributor

ILyoan commented Aug 3, 2015

@chunseoklee I think we can close this as #144 landed?

@chunseoklee
Copy link
Contributor Author

It should have been close by #106.
Now, closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants