Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix interfaces for processing values and completion values #139

Closed
ruben-ayrapetyan opened this issue Jun 1, 2015 · 2 comments
Closed
Assignees
Labels
bug Undesired behaviour ecma core Related to core ECMA functionality normal

Comments

@ruben-ayrapetyan
Copy link
Contributor

Hello.

Currently, interfaces like ecma_get_string_from_completion_value and ecma_get_string_from_value have the same prototypes, and so, can be confused.

We need to update their prototypes to check for the situation at compile-time.

@ruben-ayrapetyan
Copy link
Contributor Author

59f0109 (Ruben-fix-issue-139 branch) fixes the issue. However, it uses enum class feature, which is part of C++11.
As we do not currently use C++ features in the whole engine, opening of pull request for the patch would be delayed until the final decision about C++ usage would be made.

@LaszloLango
Copy link
Contributor

After #888, this issue is irrelevant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Undesired behaviour ecma core Related to core ECMA functionality normal
Projects
None yet
Development

No branches or pull requests

3 participants