Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Faster debug version #180

Closed
seanshpark opened this issue Jun 14, 2015 · 4 comments
Closed

Faster debug version #180

seanshpark opened this issue Jun 14, 2015 · 4 comments
Labels
enhancement An improvement normal question Raised question

Comments

@seanshpark
Copy link
Contributor

As new eval has landed, one small problem is that debug version execution has became very slow.
Can there be some level of checking so that it might be somewhat faster for debugging?

@seanshpark seanshpark added the question Raised question label Jun 14, 2015
@ILyoan
Copy link
Contributor

ILyoan commented Jun 15, 2015

It seems like rcs_chunked_list_t::get_prev() and rcs_chunked_list_t::get_next() are called too many times in debug mode. The prominent caller of them are assert_node_is_correct() and assert_list_is_correct().

@ruben-ayrapetyan
Copy link
Contributor

/CC @sand1k

@sand1k
Copy link
Contributor

sand1k commented Jun 15, 2015

Surrouned code of assert_list_is_correct(), assert_node_is_correct() and rcs_recordset_t::assert_state_is_correct() with #ifdef JERRY_HEAVY_DEBUG ... #endif, so that this checks run only for unit tests.
Pull request #193 performs the update.

@seanshpark
Copy link
Contributor Author

Nice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An improvement normal question Raised question
Projects
None yet
Development

No branches or pull requests

5 participants