Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New labels to reflect the state of PR #201

Closed
egavrin opened this issue Jun 17, 2015 · 10 comments
Closed

New labels to reflect the state of PR #201

egavrin opened this issue Jun 17, 2015 · 10 comments
Labels
discussion Ongoing discussion

Comments

@egavrin
Copy link
Contributor

egavrin commented Jun 17, 2015

We may introduce the following labels to reflect the state of PR:

  • waiting-for-review
  • waiting-to-be-fixed
  • make-push or OK-to-commit
  • etc?

I think it can be useful, both for developers and reviewers.

@egavrin egavrin added the discussion Ongoing discussion label Jun 17, 2015
@galpeter
Copy link
Contributor

AFAIK: from our side not all developers can modify labels as they don't have enough permission to do so.

@egavrin
Copy link
Contributor Author

egavrin commented Jun 17, 2015

@galpeter I think that this formality can be solved

@egavrin
Copy link
Contributor Author

egavrin commented Jun 17, 2015

@galpeter btw, do all developers from your side have rights to change the assignee?

@galpeter
Copy link
Contributor

@egavrin, no they can not modify any of the labels/milestone/assignee fields, they only can update their own PR/issue's title/description.

@egavrin
Copy link
Contributor Author

egavrin commented Jun 17, 2015

@Seo-Young what do you think about this?

@Seo-Young
Copy link
Contributor

@egavrin I think your suggestion on the labels are helpful to check the status of patches. Do you need my opinion on the modification rights on the labels/milestone/assignee fields?

@egavrin
Copy link
Contributor Author

egavrin commented Jun 18, 2015

@Seo-Young thank you! How can we enable Szeged to change or modify this fields in pr?

@Seo-Young
Copy link
Contributor

@egavrin Reviewers already has the rights for that.
In my opinion, to allow such changes to 'all the developers' is not feasible for stable operating the project.

@egavrin
Copy link
Contributor Author

egavrin commented Jun 18, 2015

@Seo-Young I'd partly agree. Giving such rights to all developers is not feasible - I agree. But Szeged team may have such rights without any problems.

@lemmaa
Copy link
Contributor

lemmaa commented Jun 18, 2015

@egavrin @Seo-Young We'd better discussing it later. We have to consider the community operating after open source release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion Ongoing discussion
Projects
None yet
Development

No branches or pull requests

4 participants