Make run_every and buffer_time to be consistent #1629
Closed
raymanound
started this conversation in
Ideas
Replies: 1 comment
-
Feel like it is an issue more #1630 |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
The
run_every
andbuffer_time
can be configured in the global config and each rule individually. I assume the rule settings will always take precedence to override the global config setting. However, they take precedence differently in different places in elastalert.py. For example,elastalert2/elastalert/elastalert.py
Line 739 in f55421b
elastalert2/elastalert/elastalert.py
Line 748 in f55421b
elastalert2/elastalert/elastalert.py
Line 599 in f55421b
I think we can set the
rule['run_every']
andrule['buffer_time']
to have the default value from the global config at the first place and make the rest of the codes always referencerule
instead ofself
to make it consistent. This can also benefit other modules that have a rule context, like Enhancements. What do you think?Beta Was this translation helpful? Give feedback.
All reactions