Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editing config file from lazygit requires a restart for changes to take effect #1158

Closed
peppy opened this issue Feb 12, 2021 · 8 comments · Fixed by #1170
Closed

Editing config file from lazygit requires a restart for changes to take effect #1158

peppy opened this issue Feb 12, 2021 · 8 comments · Fixed by #1170
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@peppy
Copy link

peppy commented Feb 12, 2021

Describe the bug
Lazygit allows you to edit its configuration by pressing the 'e' hotkey from pane 1. After editing, my expectation would be that the new configuration is loaded, but it does not seem to be.

To Reproduce
Steps to reproduce the behavior:

  1. Go to pane 1
  2. Press 'e'
  3. Edit the configuration (add a new custom command)
  4. Save and return to lazygit

Expected behavior
The new command will work immediately, without a restart.

Desktop (please complete the following information):

  • OS: macOS (latest non-beta)
  • Lazygit Version 0.24.2
@peppy peppy added the bug Something isn't working label Feb 12, 2021
@jesseduffield
Copy link
Owner

Makes sense, I suspect that wouldn't be too hard to implement. I'll see if I find some time soon to work on this but in the meantime I'll chuck a 'good-first-issue' label on it

@jesseduffield
Copy link
Owner

@peppy are you able to give #1170 a go?

@peppy
Copy link
Author

peppy commented Feb 23, 2021

works as expected 💯

@c02y
Copy link

c02y commented May 2, 2022

I'm sorry, how can I make it work?

@jesseduffield And what is the meaning of "returning to gui" in the title #1170, there is only tui for lazygit.

@peppy
Copy link
Author

peppy commented May 2, 2022

At some point I believe this did regress. I noticed that changes don't seem to stick anymore.

@c02y
Copy link

c02y commented May 2, 2022

You may need to reopen it.

@jesseduffield jesseduffield reopened this May 3, 2022
@joshgoebel
Copy link

In testing right now (on main) changing commitAuthorShortLength was instant (as soon as I switched based to lazygit).

@stefanhaller
Copy link
Collaborator

This was implemented in #3787.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants