Next major

[SimenB]

I'm thinking it's about time to make a new release dropping node 12 (and 17) and eslint 6 so that we can update our dev deps. @G-Rath any other breaking changes you wanna get it at the same time?

[G-Rath]

Yup:

• [unbound-method] don't suppress errors thrown by base rule #1172: I don't think it's breaking per say, but if we're doing a new major might as well include it
• [no-restricted-matchers] allow restricting matchers without specific modifier #1156 (comment): I think changing the behaviour to be an entire matcher makes better sense in the long run because it gives more flexibility and it just means you need to repeat a couple of lines which can easily be done with .map and shouldn't need updating so not really an extra burden
  • technically we could then remove prefer-called-with, though I'm hesitant as it makes it a little harder to use in shared configs (since if teams decide to use no-restricted-matchers they have to make sure to apply the config from the shared config too), and I think this rule is a good practice (vs the others I axed, which were stylistic)
• we should talk about what we do with no-jest-import now that we've got support for @jest/globals - I think tossing it is probably the right thing to do? fix: make no-jest-import error message more accurate #1169 (comment) (we could always reuse the name later)

I think that's all the breaking stuff, but will do a double check this week.

Also how would you feel if I made an issue over on Jest pushing (again) for removing the alised matchers, given we've got no-alias-methods as an autofix? then we could remove or deprecate that rule here in favor of no-restricted-matchers or even no-deprecated-functions (either in this major or the next).

[SimenB]

All those sounds good to me!

Happy to remove aliased matchers in next major of jest (30), but not the imminent 29 (this week)

[G-Rath]

Cool - 30 is a nice round number anyway 😄 I'll make an issue on Jest and do follow up stuff later this week. Do you want to get a next branch going?

[SimenB]

https://github.com/jest-community/eslint-plugin-jest/tree/next

[G-Rath]

Have created jestjs/jest#13164

[G-Rath]

@SimenB I think we should add no-alias-methods to recommended since we're going to remove from Jest "soon" (technically they're deprecated functions but iirc no-deprecated-functions is not yet setup for expect matchers - I guess we should think about what we want to do for that)

[SimenB]

works for me 👍

[G-Rath]

@SimenB I just remembered about #292 - it seems to me like we shouldn't need our snapshot processor anymore, so we could delete it in this major.

[SimenB]

Not sure about that one... It's unclear to me what we should do, and I don't think we should block a new release on it. Easy enough to just go with a new major if needed 🙂

[SimenB]

https://github.com/jest-community/eslint-plugin-jest/releases/tag/v27.0.0