Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide ES5 browser build for pretty-format #4002

Closed
pedrottimark opened this issue Jul 10, 2017 · 2 comments · Fixed by #4075
Closed

Provide ES5 browser build for pretty-format #4002

pedrottimark opened this issue Jul 10, 2017 · 2 comments · Fixed by #4075

Comments

@pedrottimark
Copy link
Contributor

Do you want to request a feature or report a bug?

Report an unintended regression.

What is the current behavior?

pretty-format lacks build-es5 subdirectory after the excellent improvement in #3532

See https://github.com/facebook/jest/pull/3532/files#diff-9b3b0a5fd27925d64d045cf1394e5143L11

What is the expected behavior?

There are enough dependents on pretty-format and its code goes to enough effort so an ES5 build is possible, that we will probably be sorry to publish the next version without it.

@skovhus In case there is more to consider beyond the browser property in package.json would you be willing to look at this?

@cpojer I guess this implies pretty-format never had a smoke test for the build-es5 subdirectory. Is it worth the effort to test it with the subset of ES5 values?

@skovhus
Copy link
Contributor

skovhus commented Jul 10, 2017

Should be fairly simple to add, just descoped it in #3532.

Can be solved by:

  • add browser field in package.json for pretty-format
  • add it to pretty-format to the Karma browser tests I added to ensure it works

@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants