test.only should be scoped to its describe

[dandv]

🐛 Bug Report

In a describe, I have a bunch of tests that should be executed only when a certain condition is fulfilled. One official solution is to use test.only.

The problem is that if the condition is truthy, no other test in the entire test file, that is, in different describes, gets executed. Instead, I see Pending test 'xxx' for every single test in all describes.

To Reproduce

describe('always run', () => {
  test('add', () => {
    expect(1 + 2).toBe(3);
  });
});

describe('run conditionally', () => {
  if (true) test.only('skipping all other things', () => {
    console.warn('skipping tests');
  });
  test('mul', () => {
    expect(2 * 3).toBe(6);
  })
});

Expected behavior

Only the tests in the describe block containing the test.only call should be skipped. Otherwise, test.only is a kill switch for the entire test file.

Link to repl or repo (highly encouraged)`

https://repl.it/repls/SillyPastDictionary

[thymikee]

This is certainly not a bug, but rather a feature request. We can discuss if it makes sense to scope test.only to a describe. IMHO we shouldn't, because it exists to focus on a single test case. Or a whole describe with describe.only.

[dandv]

@thymikee If I'm reading @SimenB's example correctly, the "all non-auth tests" are intended to execute whether the USER and PASSWORD are set or not. However, that's not the case.

[thymikee]

I'm pretty sure he meant separate files instead of multiple describes. It's just an example code, don't expect it to be valid.

[github-actions]

This issue is stale because it has been open for 1 year with no activity. Remove stale label or comment or this will be closed in 14 days.

[dandv]

Agree that a describe.only should focus the testing on that single describe.

A test.only within a describe.only would focus on that test.

A test.only within a describe is ambiguous. I assumed, per POLA that it would be scoped to the describe, as other tests are.

[SimenB]

I don't think we should do this. only means "only this" (or "these" if added to multiple tests) within a test suite (file), not just within its describe. This is, afaik, also the case in other test runners with the same describe API (at least mocha)

[github-actions]

This issue is stale because it has been open for 1 year with no activity. Remove stale label or comment or this will be closed in 30 days.

[github-actions]

This issue was closed because it has been stalled for 30 days with no activity. Please open a new issue if the issue is still relevant, linking to this one.

[github-actions]

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.