When an expect call fails inside jest.isolateModules the sandbox doesn't get unloaded

[maayanbar13]

🐛 Bug Report

When a test fails inside jest.isolateModules callback, the sandbox registry doesn't close, causing all other tests using isolateModules to fail.

To Reproduce

it("Should fail", () => {
  jest.isolateModules(() => {
    expect(true).toBe(false);
  });
});

it("Should pass", () => {
  jest.isolateModules(() => {
    expect(true).toBe(true);
  });
});

Expected behavior

Should fail the first tests, but the other test should pass.

Link to repl or repo (highly encouraged)

https://repl.it/@maayanbar/Jest-isolateModules

envinfo

  System:
    OS: Windows 10 10.0.18362
    CPU: (8) x64 Intel(R) Core(TM) i7-3770K CPU @ 3.50GHz
  Binaries:
    Node: 12.12.0 - D:\Program Files\nodejs\node.EXE
    Yarn: 1.19.1 - C:\Program Files (x86)\Yarn\bin\yarn.CMD
    npm: 6.11.3 - D:\Program Files\nodejs\npm.CMD

[jeysal]

Oh, what an oversight! Looks like there's just a try-finally missing that should be in the implementation of isolateModules in jest-runtime (unless I'm missing something that makes it more complicated). PRs welcome!

[doniyor2109]

Hi @jeysal. Can I work on this issue?

[SimenB]

@doniyor2109 please go for it 🙂

[github-actions]

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.